Skip to content

fix: route not found error when access to static segment route in group route #1680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 9, 2025
Merged

fix: route not found error when access to static segment route in group route #1680

merged 8 commits into from
Sep 9, 2025

Conversation

r4ai
Copy link
Contributor

@r4ai r4ai commented Sep 8, 2025 •
edited
Loading

close #1669

  • add a failing e2e test
  • fix the bug
  • add unit tests
  • refactor the code
@vercel Vercel
Copy link

vercel bot commented Sep 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
waku Ready Ready Preview Sep 8, 2025 9:42pm
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Sep 8, 2025 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.
@r4ai r4ai changed the title Issue 1669 Sep 8, 2025
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 8, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/wakujs/waku@1680

commit: 7e7a502
@r4ai r4ai marked this pull request as ready for review September 8, 2025 09:42
@r4ai r4ai mentioned this pull request Sep 8, 2025
Closed
r4ai
r4ai commented Sep 8, 2025
View reviewed changes
packages/waku/src/router/create-pages.ts
groupPathLookup.set(pagePath, definedPath);
}
const id = joinPath(...pathItems, 'page');
const id = joinPath(pagePath, 'page').replace(/^\//, '');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it to use groupless path.
This should be the same as what the static page without slugs does:

https://github.com/r4ai/waku/blob/01b1d3c8bcf833fd9c128d7c534536adedc90e75/packages/waku/src/router/create-pages.ts#L451-L456

As a result, the route path should be retrieved by the following if statement, and the error should be fixed.

https://github.com/r4ai/waku/blob/01b1d3c8bcf833fd9c128d7c534536adedc90e75/packages/waku/src/router/create-pages.ts#L343-L345
@dai-shi dai-shi requested a review from tylersayshi September 8, 2025 10:43
tylersayshi
tylersayshi approved these changes Sep 8, 2025
View reviewed changes
Copy link
Member

@tylersayshi tylersayshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep! this looks right to me, thanks for the fix!
@dai-shi dai-shi mentioned this pull request Sep 7, 2025
Open
@dai-shi dai-shi merged commit c99e983 into wakujs:main Sep 9, 2025
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@r4ai @tylersayshi @dai-shi