Skip to content

feat: allow optionally controlled root #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 8, 2024
Merged

feat: allow optionally controlled root #952

merged 14 commits into from
Oct 8, 2024

Conversation

tylersayshi
Copy link
Member

@tylersayshi tylersayshi commented Oct 6, 2024 •
edited
Loading

Adds support for createRoot in createPages api and _root.tsx in fs-router mode for controlling the top level html and head tags

this will allow for controlling the top level tags, while still keeping a static default of the following:

    <html>
      <head></head>
      <body>{children}</body>
    </html>
@vercel Vercel
Copy link

vercel bot commented Oct 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Oct 7, 2024 1:08pm
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Oct 6, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.
tylersayshi
tylersayshi commented Oct 6, 2024
View reviewed changes
@dai-shi dai-shi mentioned this pull request Oct 6, 2024
Open
dai-shi
dai-shi reviewed Oct 6, 2024
View reviewed changes
@tylersayshi tylersayshi marked this pull request as ready for review October 6, 2024 06:15
@tylersayshi
Copy link
Member Author

@dai-shi do you know why pnpm install is failing on the CI checks? I can't see anything I might've changed... or maybe I'm misreading the logs, honestly unsure
dai-shi
dai-shi reviewed Oct 6, 2024
View reviewed changes
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1st review
dai-shi
dai-shi reviewed Oct 7, 2024
View reviewed changes
@tylersayshi tylersayshi mentioned this pull request Oct 7, 2024
Merged
dai-shi pushed a commit that referenced this pull request Oct 7, 2024
@tylersayshi
chore: lint for curly brackets and fix (#956)
94a05d6 
follow up to:
#952 (comment)

---------

Co-authored-by: Tyler <26290074+thegitduck@users.noreply.github.com>
dai-shi
dai-shi approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@dai-shi dai-shi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Merging this, but could you add a PR description? It would be nice if it's detailed.
e2e/fixtures/partial-build/src/pages/_root.tsx

export const getConfig = async () => {
return {
render: 'static',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the default, right?

I wonder if we need _root.tsx for partial-build fixture. Is there any reason you created this file?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created this just so that we had a test case that used the _root.tsx file.

If the presence of _root.tsx broke the build for any reason, having this here should catch that.

I'll update the description tho!
@dai-shi dai-shi merged commit 087d654 into wakujs:main Oct 8, 2024
24 checks passed
yokos2 added a commit to yokos2/react-yoko-portfolio that referenced this pull request Feb 8, 2025
@yokos2 @tylersayshi
chore: lint for curly brackets and fix (#956)
26e159d 
follow up to:
wakujs/waku#952 (comment)

---------

Co-authored-by: Tyler <26290074+thegitduck@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@tylersayshi @dai-shi