-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Map display, display-contents, display-flow-root, display-list-item, display-ruby, display-table web-features
#56758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…-item`, `display-ruby`, `display-table` web-features Features: `display`, `display-contents`, `display-flow-root`, `display-list-item`, `display-ruby`, & `display-table` Reference: https://github.com/web-platform-dx/web-features/blob/main/features/display.yml Reference: https://github.com/web-platform-dx/web-features/blob/main/features/display-contents.yml Reference: https://github.com/web-platform-dx/web-features/blob/main/features/display-flow-root.yml Reference: https://github.com/web-platform-dx/web-features/blob/main/features/display-list-item.yml Reference: https://github.com/web-platform-dx/web-features/blob/main/features/display-ruby.yml Reference: https://github.com/web-platform-dx/web-features/blob/main/features/display-table.yml I did these as a cluster as I was expecting overlap. Notable exclusions: 1. `parsing` tests in `css/css-display/parsing`, I am reluctantly excluding these because they are already mapped to `two-value-display` and they do all include tests for two values being passed into display 2. `reading-flow` tests in `css/css-display/reading-flow/` - separate feature. 3. `run-in` tests in `css/css-display/run-in/` - separate feature.
|
cc @foolip @jugglinmike the merge conflicts on css/css-ruby/WEB_FEATURES.yml are a little thorny here. I agree with the suggested changes here and think we should use the I think the already mapped If folks agree, I can make those changes here and continue resolving the merge conflicts! |
I agree, the ruby feature should be mapped primarily to things in the html/ directory. Maybe there are some things in css/ which can be considered tests for ruby markup (as opposed to |
Necessary after merge conflict resolution here: web-platform-tests@b786083#diff-dd0ebb949a3681e4d4a3a614ae8bd9841352724a779e8f3d0a4ad6a124d92536R4
Ok I re-mapped the I think this is ready for re-review! |
Features:
display,display-contents,display-flow-root,display-list-item,display-ruby, &display-tableReference: https://github.com/web-platform-dx/web-features/blob/main/features/display.yml
Reference: https://github.com/web-platform-dx/web-features/blob/main/features/display-contents.yml
Reference: https://github.com/web-platform-dx/web-features/blob/main/features/display-flow-root.yml
Reference: https://github.com/web-platform-dx/web-features/blob/main/features/display-list-item.yml
Reference: https://github.com/web-platform-dx/web-features/blob/main/features/display-ruby.yml
Reference: https://github.com/web-platform-dx/web-features/blob/main/features/display-table.yml
I did these as a cluster as I was expecting overlap.
Notable exclusions:
parsingtests incss/css-display/parsing, I am reluctantly excluding these because they are already mapped totwo-value-displayand they do all include tests for two values being passed into displayreading-flowtests incss/css-display/reading-flow/- separate feature.run-intests incss/css-display/run-in/- separate feature.