Skip to content

Conversation

@stalgiag
Copy link
Contributor

@stalgiag stalgiag commented Dec 15, 2025

Features: display, display-contents, display-flow-root, display-list-item, display-ruby, & display-table

Hello, reviewers! As of 2025-12-05, the wpt-pr-bot is requesting reviews from code owners for changes to WEB_FEATURES.yml files. To learn more about the purpose of these files, check out this presentation from TPAC 2025, Annotating WPT to Surface the Status of the Platform.

Reference: https://github.com/web-platform-dx/web-features/blob/main/features/display.yml
Reference: https://github.com/web-platform-dx/web-features/blob/main/features/display-contents.yml
Reference: https://github.com/web-platform-dx/web-features/blob/main/features/display-flow-root.yml
Reference: https://github.com/web-platform-dx/web-features/blob/main/features/display-list-item.yml
Reference: https://github.com/web-platform-dx/web-features/blob/main/features/display-ruby.yml
Reference: https://github.com/web-platform-dx/web-features/blob/main/features/display-table.yml

I did these as a cluster as I was expecting overlap.

Notable exclusions:

  1. parsing tests in css/css-display/parsing, I am reluctantly excluding these because they are already mapped to two-value-display and they do all include tests for two values being passed into display
  2. reading-flow tests in css/css-display/reading-flow/ - separate feature.
  3. run-in tests in css/css-display/run-in/ - separate feature.
…-item`, `display-ruby`, `display-table` web-features

Features: `display`, `display-contents`, `display-flow-root`, `display-list-item`, `display-ruby`, & `display-table`

Reference: https://github.com/web-platform-dx/web-features/blob/main/features/display.yml
Reference: https://github.com/web-platform-dx/web-features/blob/main/features/display-contents.yml
Reference: https://github.com/web-platform-dx/web-features/blob/main/features/display-flow-root.yml
Reference: https://github.com/web-platform-dx/web-features/blob/main/features/display-list-item.yml
Reference: https://github.com/web-platform-dx/web-features/blob/main/features/display-ruby.yml
Reference: https://github.com/web-platform-dx/web-features/blob/main/features/display-table.yml

I did these as a cluster as I was expecting overlap.

Notable exclusions:
1. `parsing` tests in `css/css-display/parsing`, I am reluctantly excluding these because they are already mapped to `two-value-display` and they do all include tests for two values being passed into display
2. `reading-flow` tests in `css/css-display/reading-flow/` - separate feature.
3. `run-in` tests in `css/css-display/run-in/` - separate feature.
@ChrisC
Copy link
Contributor

ChrisC commented Jan 20, 2026

cc @foolip @jugglinmike the merge conflicts on css/css-ruby/WEB_FEATURES.yml are a little thorny here. I agree with the suggested changes here and think we should use the * pattern to map to the display-ruby feature (which is more about the css rendering). I think that's the primary concern of most of the tests in the css/css-ruby directory.

I think the already mapped ruby web feature(which is primarily about the HTML element) should instead be re-mapped to the tests in html/semantics/text-level-semantics/the-ruby-element.

If folks agree, I can make those changes here and continue resolving the merge conflicts!

@foolip
Copy link
Member

foolip commented Jan 23, 2026

cc @foolip @jugglinmike the merge conflicts on css/css-ruby/WEB_FEATURES.yml are a little thorny here. I agree with the suggested changes here and think we should use the * pattern to map to the display-ruby feature (which is more about the css rendering). I think that's the primary concern of most of the tests in the css/css-ruby directory.

I think the already mapped ruby web feature(which is primarily about the HTML element) should instead be re-mapped to the tests in html/semantics/text-level-semantics/the-ruby-element.

If folks agree, I can make those changes here and continue resolving the merge conflicts!

I agree, the ruby feature should be mapped primarily to things in the html/ directory. Maybe there are some things in css/ which can be considered tests for ruby markup (as opposed to display: ruby) but certainly not all of https://wpt.fyi/results/css/css-ruby?label=master&label=experimental&aligned&q=feature%3Aruby.

@ChrisC
Copy link
Contributor

ChrisC commented Jan 29, 2026

I agree, the ruby feature should be mapped primarily to things in the html/ directory. Maybe there are some things in css/ which can be considered tests for ruby markup (as opposed to display: ruby) but certainly not all of https://wpt.fyi/results/css/css-ruby?label=master&label=experimental&aligned&q=feature%3Aruby.

Ok I re-mapped the ruby web feature in 5e3d20c and confirmed (imo) that there is no overlap with any of the tests in css/css-ruby(which are all primarily about CSS rendering behavior and now mapped to display-ruby).

I think this is ready for re-review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment