Editorial: fix COOP argument, variable, and link mix-ups - #13026
Open
shannonbooth wants to merge 5 commits into
Open
shannonbooth wants to merge 5 commits into
shannonbooth wants to merge 5 commits into
Conversation
"Check if enforcing report-only COOP would require a browsing context group switch" referred to activeDocumentCOOPReportOnly, but its parameter is named activeDocumentCOOP.
activeDocumentCOOPValue is already an opener policy value, so it has no value of its own.
"Queue violation reports for accesses" linked to "queue a violation report for access to an opened window" when neither window opened the other, although the text and arguments are those of "queue a violation report for access to another window".
"Queue a violation report for access from an opened window" set effectivePolicy to an undefined coopValue and property to the report-only value. Use the report-only value and propertyName respectively, as the other access reports do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While implementing COOP, I ran into "enforce a response's opener policy" not passing "check if COOP values require a browsing context group switch" in an order that matches its declaration. Reviewing that fix with AI turned up a few more issues nearby, which this fixes too.
Changes:
Reporting integration seems to have some further problems (some normative?), but I've tried keeping this to editorial fixes.
/browsers.html ( diff )