Skip to content

Conversation

@ematipico
Copy link
Member

@ematipico ematipico commented Jan 20, 2026

Changes

Closes #14952

This PR stabilise experimentalStaticHeaders.

It doesn't add any new APIs, and it keeps the existing semantics.

Testing

Updated the fixtures, tests should still pass

Docs

withastro/docs#13159

@changeset-bot
Copy link

changeset-bot bot commented Jan 20, 2026

🦋 Changeset detected

Latest commit: a863102

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: example Related to an example package (scope) pkg: astro Related to the core `astro` package (scope) docs pr labels Jan 20, 2026
@ematipico ematipico changed the title feat: static headers Jan 20, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026

⚠️ Package Trust Level Decreased

Caution

Decreased trust levels may indicate a higher risk of supply chain attacks. Please review these changes carefully.

📦 Package �� Before 🔓 After
eslint-plugin-regexp trusted-with-provenance none
@cloudflare/kv-asset-handler trusted-with-provenance none
@cloudflare/unenv-preset trusted-with-provenance none
workerd trusted-with-provenance none
@sveltejs/vite-plugin-svelte-inspector trusted-with-provenance provenance
@sveltejs/vite-plugin-svelte trusted-with-provenance provenance
jsdoc-type-pratt-parser trusted-with-provenance none
miniflare trusted-with-provenance none
youch provenance none
@cloudflare/workerd-darwin-64 trusted-with-provenance none
@cloudflare/workerd-darwin-arm64 trusted-with-provenance none
@cloudflare/workerd-linux-64 trusted-with-provenance none
@cloudflare/workerd-linux-arm64 trusted-with-provenance none
@cloudflare/workerd-windows-64 trusted-with-provenance none
wrangler trusted-with-provenance none
@matthewp
Copy link
Contributor

Here's the issue this is for: #14952

@matthewp
Copy link
Contributor

I don't quite understand what this API is for. I understand that for CSP we have some headers that we want to tell the adapters about. What is wrong with the approach we're already doing here? Are there other use-cases?

@ematipico ematipico force-pushed the feat/static-headers branch from 94d94cd to 141d613 Compare January 27, 2026 16:03
@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Jan 27, 2026
@ematipico ematipico marked this pull request as ready for review January 28, 2026 10:54
@ematipico ematipico force-pushed the feat/static-headers branch from b549d9f to bcfb60f Compare January 28, 2026 11:41
@ematipico ematipico force-pushed the feat/static-headers branch from bcfb60f to 3c19939 Compare January 28, 2026 11:55
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 28, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing feat/static-headers (a863102) with next (0a9777e)1

Summary

✅ 9 untouched benchmarks
⏩ 9 skipped benchmarks2

Footnotes

  1. No successful run was found on next (cdb99c8) during the generation of this report, so 0a9777e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@ematipico ematipico requested a review from matthewp January 28, 2026 13:15
Base automatically changed from next to main January 30, 2026 17:31
An error occurred while trying to automatically change base from next to main January 30, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs pr pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope) pkg: integration Related to any renderer integration (scope)

3 participants