-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Embedded langs in <Code /> #15298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Embedded langs in <Code /> #15298
Conversation
🦋 Changeset detectedLatest commit: c05d9c9 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
| 📦 Package | 🔒 Before | 🔓 After |
|---|---|---|
| eslint-plugin-regexp | trusted-with-provenance | none |
| @cloudflare/kv-asset-handler | trusted-with-provenance | none |
| @cloudflare/unenv-preset | trusted-with-provenance | none |
| workerd | trusted-with-provenance | none |
| @sveltejs/vite-plugin-svelte-inspector | trusted-with-provenance | provenance |
| @sveltejs/vite-plugin-svelte | trusted-with-provenance | provenance |
| jsdoc-type-pratt-parser | trusted-with-provenance | none |
| miniflare | trusted-with-provenance | none |
| youch | provenance | none |
| @cloudflare/workerd-darwin-64 | trusted-with-provenance | none |
| @cloudflare/workerd-darwin-arm64 | trusted-with-provenance | none |
| @cloudflare/workerd-linux-64 | trusted-with-provenance | none |
| @cloudflare/workerd-linux-arm64 | trusted-with-provenance | none |
| @cloudflare/workerd-windows-64 | trusted-with-provenance | none |
| wrangler | trusted-with-provenance | none |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jfrancos
Contributors are responsible of the docs, so yes you send a PR to the docs repository. Doing the english translation is more than enough
9a4a5ea to
f284901
Compare
|
Thanks @ematipico. I've added more detail to the changeset. |
|
f284901 to
6e5ae1e
Compare
|
Sorry about the close. |
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
8562ae1 to
c05d9c9
Compare
No worries @matthewp @florian-lefebvre thanks for the corrections |
Changes
This PR addresses #15271 adding an optional
embeddedLangsprop to<Code />:<Code />creates a shiki highlighter withlangs: [lang].langs.langsparam for shiki to correctly highlightlangs: [lang, ...embeddedLangs]Testing
langssupport, settinglangto "vue" results in the main line of TSX being one long<span />.langssupport, each TSX token is its own<span /><span />containing the lone string "const"Docs
Docs will need an update here (can I do this for
en? Would I submit an issue there first or just a PR?)/cc @withastro/maintainers-docs