Skip to content

Conversation

@florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Jan 28, 2026

Changes

  • Adds the e18e eslint plugin to modernize the codebase
  • Also enables some related biome rules
  • Switching from js-yaml to yaml uncovered a bug in the netlify adapter. Updated to match what we do for vercel

Testing

Should pass

Docs

Changeset

@florian-lefebvre florian-lefebvre self-assigned this Jan 28, 2026
@changeset-bot
Copy link

changeset-bot bot commented Jan 28, 2026

🦋 Changeset detected

Latest commit: 27c57a7

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2026

⚠️ Package Trust Level Decreased

Caution

Decreased trust levels may indicate a higher risk of supply chain attacks. Please review these changes carefully.

📦 Package 🔒 Before 🔓 After
eslint-plugin-regexp trusted-with-provenance none
@cloudflare/kv-asset-handler trusted-with-provenance none
@cloudflare/unenv-preset trusted-with-provenance none
workerd trusted-with-provenance none
@sveltejs/vite-plugin-svelte-inspector trusted-with-provenance provenance
@sveltejs/vite-plugin-svelte trusted-with-provenance provenance
jsdoc-type-pratt-parser trusted-with-provenance none
miniflare trusted-with-provenance none
youch provenance none
@cloudflare/workerd-darwin-64 trusted-with-provenance none
@cloudflare/workerd-darwin-arm64 trusted-with-provenance none
@cloudflare/workerd-linux-64 trusted-with-provenance none
@cloudflare/workerd-linux-arm64 trusted-with-provenance none
@cloudflare/workerd-windows-64 trusted-with-provenance none
wrangler trusted-with-provenance none
@ematipico
Copy link
Member

FYI some of the rules that e18e has, are already implemented in Biome. Just need to enable them

@github-actions github-actions bot added feat: markdown Related to Markdown (scope) pkg: react Related to React (scope) pkg: preact Related to Preact (scope) pkg: integration Related to any renderer integration (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: astro Related to the core `astro` package (scope) labels Jan 28, 2026
@github-actions github-actions bot added the pkg: example Related to an example package (scope) label Jan 28, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 30, 2026

Merging this PR will not alter performance

✅ 9 untouched benchmarks


Comparing chore/eslint-e18e (27c57a7) with next (89b6cdd)1

Open in CodSpeed

Footnotes

  1. No successful run was found on next (6f88013) during the generation of this report, so 89b6cdd was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Base automatically changed from next to main January 30, 2026 17:31
An error occurred while trying to automatically change base from next to main January 30, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: example Related to an example package (scope) pkg: integration Related to any renderer integration (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope)

3 participants