-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
feat: Smartypants config #15340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
feat: Smartypants config #15340
Conversation
🦋 Changeset detectedLatest commit: fb96265 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodSpeed Performance ReportMerging this PR will create unknown performance changesComparing Summary
Footnotes
|
|
Awesome work! This is very nice. Unless something special happens, 5.17 was the last minor for the 5.x series of Astro. Would you be willing to rebase this PR onto the |
this file is used to autogenerate the configuration reference documentation
131cd45 to
4f302de
Compare
Thanks for letting me know, rebase is done! EDIT: Just some type errors to fix for me so the tests pass again 👍 EDIT 2: Actually, I am really not sure how to fix this error. It seems like a mismatch with Do you know how to fix this, Erika? |
|
| 📦 Package | 🔒 Before | 🔓 After |
|---|---|---|
| eslint-plugin-regexp | trusted-with-provenance | none |
| @cloudflare/kv-asset-handler | trusted-with-provenance | none |
| @cloudflare/unenv-preset | trusted-with-provenance | none |
| workerd | trusted-with-provenance | none |
| @sveltejs/vite-plugin-svelte-inspector | trusted-with-provenance | provenance |
| @sveltejs/vite-plugin-svelte | trusted-with-provenance | provenance |
| jsdoc-type-pratt-parser | trusted-with-provenance | none |
| miniflare | trusted-with-provenance | none |
| youch | provenance | none |
| @cloudflare/workerd-darwin-64 | trusted-with-provenance | none |
| @cloudflare/workerd-darwin-arm64 | trusted-with-provenance | none |
| @cloudflare/workerd-linux-64 | trusted-with-provenance | none |
| @cloudflare/workerd-linux-arm64 | trusted-with-provenance | none |
| @cloudflare/workerd-windows-64 | trusted-with-provenance | none |
| wrangler | trusted-with-provenance | none |
Changes
Adapt
markdown.smartypantsconfiguration to allow passing more detailed object.I recreated the types for this new option object, as
remark-smartypantsunfortunately doesn't reexport theOptiontype fromretext-smartypants... Maybe someone has a clever idea how to do this without a redefinition (but we need the Zod schema as well anyways) 🤔Related: withastro/roadmap#1027
Testing
Added new e2e test cases covering some of the options, as I think the
remark-smartypantsplugin should verify that all options work, so therefore, not all are covered here.Docs
I adapted the https://github.com/withastro/astro/blob/main/packages/astro/src/types/public/config.ts file which will autogenerate the new configuration reference.
I set the Astro version for the new docs to
5.18.0as I assume, this could be reviewed until the next minor, as5.17.0was just released, but no pressure or rush, we can adopt this version number if it needs more time or is not the priority right now!