Skip to content

fix: prevent .sql files from being moved to client assets during SSR build #15345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
matthewp wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

fix: prevent .sql files from being moved to client assets during SSR build #15345

matthewp wants to merge 10 commits into from
+343 −490

Conversation

@matthewp
Copy link
Contributor

@matthewp matthewp commented Jan 29, 2026 •
edited
Loading

Changes

  • Fixes an issue where .sql files (and other non-asset module types) were incorrectly moved to the client _astro/ folder during SSR builds, causing "no such module" errors at runtime.
  • The ssrMoveAssets function now uses the Vite manifest to determine which files are actual client assets (CSS and static assets like images) and only moves those files.
  • Server-side module files like .sql now stay in the server directory where they belong.
  • This is a rather big change but makes it so that only client-side assets are moved to the client/ folder.

Testing

  • Added a new test in the Cloudflare adapter (sql-import.test.js) that verifies .sql file imports work correctly in both dev and build modes.

Docs

N/A, bug fix
@matthewp
fix: prevent .sql files from being moved to client assets during SSR …
260e4f7 
…build

- Use Vite manifest to determine which files are actual client assets
- Only move files listed in css/assets arrays of manifest chunks
- Add test for .sql file imports in Cloudflare adapter
@changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: 42249cf

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR
@github-actions github-actions bot added feat: markdown Related to Markdown (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: example Related to an example package (scope) 🚨 action Modifies GitHub Actions pkg: react Related to React (scope) pkg: preact Related to Preact (scope) pkg: solid Related to Solid (scope) pkg: integration Related to any renderer integration (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: astro Related to the core `astro` package (scope) docs pr labels Jan 29, 2026
@matthewp matthewp changed the base branch from main to next January 29, 2026 20:42
@github-actions github-actions bot removed feat: markdown Related to Markdown (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: react Related to React (scope) pkg: preact Related to Preact (scope) pkg: solid Related to Solid (scope) pkg: integration Related to any renderer integration (scope) pkg: create-astro Related to the `create-astro` package (scope) labels Jan 29, 2026
@matthewp matthewp self-assigned this Jan 29, 2026
@matthewp
chore(cloudflare): remove cloudflareModuleLoader
dca7930 
The Cloudflare Vite plugin now handles additional module types natively,
making the custom cloudflareModuleLoader unnecessary.

- Remove cloudflareModuleLoader plugin
- Remove cloudflareModules option from adapter options
- Remove module-loader tests and fixtures
@github-actions github-actions bot added pkg: integration Related to any renderer integration (scope) and removed pkg: example Related to an example package (scope) 🚨 action Modifies GitHub Actions docs pr labels Jan 29, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 29, 2026 •
edited
Loading

⚠️ Package Trust Level Decreased

Caution

Decreased trust levels may indicate a higher risk of supply chain attacks. Please review these changes carefully.

📦 Package 🔒 Before 🔓 After
eslint-plugin-regexp trusted-with-provenance none
@cloudflare/kv-asset-handler trusted-with-provenance none
@cloudflare/unenv-preset trusted-with-provenance none
workerd trusted-with-provenance none
@sveltejs/vite-plugin-svelte-inspector trusted-with-provenance provenance
@sveltejs/vite-plugin-svelte trusted-with-provenance provenance
jsdoc-type-pratt-parser trusted-with-provenance none
miniflare trusted-with-provenance none
youch provenance none
@cloudflare/workerd-darwin-64 trusted-with-provenance none
@cloudflare/workerd-darwin-arm64 trusted-with-provenance none
@cloudflare/workerd-linux-64 trusted-with-provenance none
@cloudflare/workerd-linux-arm64 trusted-with-provenance none
@cloudflare/workerd-windows-64 trusted-with-provenance none
wrangler trusted-with-provenance none
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 29, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 9 untouched benchmarks

Comparing sql-import (42249cf) with main (955edb9)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (a29e171) during the generation of this report, so 955edb9 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
Base automatically changed from next to main January 30, 2026 17:31
An error occurred while trying to automatically change base from next to main January 30, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)

2 participants

@matthewp