Fix astro check failing to resolve dependencies from the project directory#17190
Open
eldardada wants to merge 1 commit into
Open
Fix astro check failing to resolve dependencies from the project directory#17190eldardada wants to merge 1 commit into
eldardada wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 2c59592 The changes in this PR will be included in the next version bump. This PR includes changesets to release 392 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
the
pkg: astro
eldardada
force-pushed
the
fix/cli-resolve-deps-from-project
branch
from
cc25645 to
b89c4bc
Compare
eldardada
force-pushed
the
fix/cli-resolve-deps-from-project
branch
from
b89c4bc to
2c59592
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
astro check(and any command that auto-installs dependencies throughgetPackage) failed to findtypescriptand@astrojs/checkwhen Astro itself is installed outside the project directory (e.g. a pnpm global/virtual store, or a monorepo where the store isn't under the project).getPackageresolved the dependency withrequire.resolve(pkg, { paths: [cwd] })but then loaded it with a bareimport(pkg). A bare specifier resolves relative to Astro's own location, not the project, so the import threwERR_MODULE_NOT_FOUNDeven though the package existed in the project.pathToFileURL(...), so dependencies are loaded from the project directory. The same fix is applied to the post-install import path. Resolving first withrequire.resolveis preserved (it also avoids caching a failed ESM import before installing).astropatch).Fixes #17135.
Testing
packages/astro/test/units/cli/install-package.test.ts: installs a dependency only inside a temporary project'snode_modules(outside Astro's resolution scope) and assertsgetPackageloads it from the providedcwd. This fails on the old bare-importbehavior and passes with the fix.pnpm --filter astro exec astro-scripts test "test/units/cli/install-package.test.ts" --strip-types→ 1 passing.biome check,prettier --check, andeslintpass on the changed files.Docs
No docs changes needed — this restores the documented behavior (resolving dependencies from the user's project) without changing any public API.