feat(csp): support for -elem and -attr directives#17214
Draft
ematipico wants to merge 2 commits into
Draft
Conversation
Merging this PR will degrade performance by 23.97%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes |
🦋 Changeset detectedLatest commit: a2c422f The changes in this PR will be included in the next version bump. This PR includes changesets to release 392 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Closes #16233
This PR enhance Astro CSP by adding support for
script-src-elem,script-src-attr,style-src-elemandstyle-src-attr.These are specific directives.
In order to make the change as minimal as possible, I enhanced the existing configuration and APIs with addition of a
kindfield. It's an enum that accepts the following values:element: store the resource in the-elemdirectiveattribute: store the resource in the-attrdirectivedefault: the existing behaviourI updated the configuration to reflect the new changes, so now the users can pass objects too (other than strings).
There's an important change in logic:
As for the built-in resources, the ones created by Astro (client islands, responsive images, fonts, etc.), they are automatically added to the more specific directive in case there's at least one.
Testing
Added various tests
Docs
Need to create a new PR
/cc @withastro/maintainers-docs for feedback!