Add edgeFunctions to Netlify adapter devFeatures to allow disabling edge function emulation#17245
Open
astrobot-houston wants to merge 1 commit into
Open
Add edgeFunctions to Netlify adapter devFeatures to allow disabling edge function emulation#17245astrobot-houston wants to merge 1 commit into
edgeFunctions to Netlify adapter devFeatures to allow disabling edge function emulation#17245astrobot-houston wants to merge 1 commit into
Conversation
…edge function emulation (#17244)
1 task
🦋 Changeset detectedLatest commit: 16c0dfe The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
I wonder if there might be an alternative fix to #17244, other than the suggested one, which apparently disables edge functions altogether in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
edgeFunctionsto thedevFeaturesadapter option so users can disable Netlify Edge Function emulation duringastro dev. Some npm packages (e.g.node-html-parser) access the filesystem at initialization and fail inside the Deno sandbox with "Reading or writing files with Edge Functions is not supported yet." SettingdevFeatures: { edgeFunctions: false }works around this — edge functions still work in production and vianetlify dev.trueto preserve existing behavior.Closes #17244
Testing
@netlify/vite-plugin's existingedgeFunctions.enabledoption; existing integration tests already cover edge function emulation when enabled. Fix was verified against the reporter's reproduction repo.Docs
NetlifyIntegrationConfigand in the changeset.