Fix route generator throwing on a dynamic param value of 0#17247
Open
chatman-media wants to merge 1 commit into
Open
Fix route generator throwing on a dynamic param value of 0#17247chatman-media wants to merge 1 commit into
chatman-media wants to merge 1 commit into
Conversation
getParameter() used truthy checks (!params[x], || '') instead of
checking for undefined, so a param legitimately set to 0 (e.g. a
zero-indexed category id) either threw TypeError: Missing parameter
or got silently dropped from the path. Reachable through the public
paginate() API: paginate(posts, { params: { categoryId: 0 } }) would
crash. Added tests covering both the spread and dynamic-segment
branches.
🦋 Changeset detectedLatest commit: e630160 The changes in this PR will be included in the next version bump. This PR includes changesets to release 394 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
the
pkg: astro
Merging this PR will not alter performance
Comparing 
|
itxaiohanglover
left a comment
itxaiohanglover
left a comment
There was a problem hiding this comment.
Clean fix — switching from truthy checks to ?? and === undefined correctly handles 0 as a valid param value. The changeset and test coverage are solid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`getParameter` in the route generator was using truthy checks (`!params[x]`, `|| ''`) instead of checking for `undefined`. That means a param that's legitimately `0` — like a zero-indexed category id — either throws `TypeError: Missing parameter` or gets silently dropped from the generated path. It's reachable through the public API too: `paginate(posts, { params: { categoryId: 0 } })` throws.
Switched to `=== undefined` / `??` so falsy-but-valid values pass through correctly, and added tests for both the dynamic-segment and spread-segment branches.