Skip dev server setup in configureServer when running inside Vitest#17248
Open
astrobot-houston wants to merge 1 commit into
Open
Skip dev server setup in configureServer when running inside Vitest#17248astrobot-houston wants to merge 1 commit into
configureServer when running inside Vitest#17248astrobot-houston wants to merge 1 commit into
Conversation
…namicImport crash (#16275)
1 task
🦋 Changeset detectedLatest commit: 2b7415e The changes in this PR will be included in the next version bump. This PR includes changesets to release 392 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16275
Changes
process.env.VITESTis set,configureServerinvite-plugin-astro-servernow returns early instead of setting up Astro's dev server middleware. Vitest's browser mode (used by the Storybook vitest runner) boots its own Vite server, which triggers this hook — but its module evaluator doesn't implementwrapDynamicImport, causing aTypeErrorwhen Astro's SSR runner tries to loadcreateAstroServerAppvia dynamic imports.astro dev, so skipping it in Vitest contexts is safe.Testing
packages/astro/test/units/vite-plugin-astro-server/vitest-guard.test.tswith two cases: one confirming the early return whenVITESTis set (using a bare fake server with no environments), and one confirming normal execution proceeds whenVITESTis absent.Docs