Skip to content

Add --exclude=<hooks> argument to wp cron event run - #97

Merged
danielbachhuber merged 7 commits into
wp-cli:mainfrom
rutviksavsani:issue/55
May 25, 2023
Merged

Add --exclude=<hooks> argument to wp cron event run#97
danielbachhuber merged 7 commits into
wp-cli:mainfrom
rutviksavsani:issue/55

Conversation

@rutviksavsani

@rutviksavsani rutviksavsani commented May 24, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fix #55

  • This pull request adds the --exclude flag to the wp cron event run command.
  • The flag accepts a list of comma separated hooks that will be excluded from the list of events.

Working:

  • Without the exclude flag

image

  • With the exclude flag

image
@rutviksavsani
rutviksavsani requested a review from a team as a code owner May 24, 2023 13:48
@danielbachhuber danielbachhuber changed the title Add exclude flag in wp cron event run command. May 25, 2023
danielbachhuber
danielbachhuber reviewed May 25, 2023
View reviewed changes

@danielbachhuber danielbachhuber left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! Just a couple nits to address.
Comment thread src/Cron_Event_Command.php Outdated
Comment thread src/Cron_Event_Command.php Outdated
@wojsmol

wojsmol commented May 25, 2023

Copy link
Copy Markdown
Contributor

@rutviksavsani Please update Issue: #55 to Fix #55 so Github will auto close related issue on PR merge.
rutviksavsani and others added 2 commits May 25, 2023 18:48
@rutviksavsani @danielbachhuber
Update flag description.
d8df3d0 
Co-authored-by: Daniel Bachhuber <daniel@bachhuber.co>
@rutviksavsani
Increase readability.
c1c07d1
@rutviksavsani

rutviksavsani commented May 25, 2023

Copy link
Copy Markdown
Contributor Author

Hi @danielbachhuber
I have addressed the feedback as suggested.
Thanks!
@danielbachhuber

danielbachhuber commented May 25, 2023

Copy link
Copy Markdown
Member

I have addressed the feedback as suggested.

@rutviksavsani Awesome, thanks! I added one more test with f879760

Nice work on this 😊
@danielbachhuber danielbachhuber added this to the 2.2.2 milestone May 25, 2023
@danielbachhuber
danielbachhuber merged commit c63ac49 into wp-cli:main May 25, 2023
@Mike-Hermans Mike-Hermans mentioned this pull request Jun 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment