Set 'utf8mb4' when exporting without '--default-character-set' option - #199
Conversation
|
@schlessera What if the database is in utf8 and by setting utf8mb4 as default same backup script will be broken? |
|
@wojsmol Good question. As far as I know, But I'm not an expert in DB encodings. Am I maybe missing something here? |
|
Regarding characters maybe, but for shore there are deferences in length of the indexes - see this make/core blog post linked in the original issue. |
|
@wojsmol I now added a detection of the actual character set of the What do you think about that approach? |
Fixes: #144
I'm not sure whether this approach is correct.
Kindly check this PR in your time.