Skip to content

Fix PHP 8.1 fatal error with --orderby=size and --size_format=mb - #230

Merged
danielbachhuber merged 2 commits into
masterfrom
229-size-format-fail
Oct 13, 2022
Merged

Fix PHP 8.1 fatal error with --orderby=size and --size_format=mb#230
danielbachhuber merged 2 commits into
masterfrom
229-size-format-fail

Conversation

@danielbachhuber

Copy link
Copy Markdown
Member

See #229

@schlessera schlessera changed the title Fix PHP 8.1 fatal error with --orderby=size and --size_format=mb Oct 13, 2022
@schlessera schlessera added this to the 2.0.23 milestone Oct 13, 2022
@schlessera schlessera added the bug label Oct 13, 2022
@schlessera

Copy link
Copy Markdown
Member

@danielbachhuber This is still in draft. Was there something else you wanted to add/change?

@danielbachhuber
danielbachhuber marked this pull request as ready for review October 13, 2022 20:38
@danielbachhuber
danielbachhuber requested a review from a team as a code owner October 13, 2022 20:38
@danielbachhuber

Copy link
Copy Markdown
Member Author

This is still in draft. Was there something else you wanted to add/change?

@schlessera Sorry, I forgot to flip the bit after I built the Phar.

@danielbachhuber
danielbachhuber merged commit 0d9e365 into master Oct 13, 2022
@delete-merged-branch
delete-merged-branch Bot deleted the 229-size-format-fail branch October 13, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment