Skip to content

Bail with a warning when deleting custom post types without --force - #188

Merged
schlessera merged 12 commits into
wp-cli:masterfrom
Mte90:delete
Dec 12, 2018
Merged

Bail with a warning when deleting custom post types without --force#188
schlessera merged 12 commits into
wp-cli:masterfrom
Mte90:delete

Conversation

@Mte90

@Mte90 Mte90 commented Jul 20, 2018

Copy link
Copy Markdown
Contributor

Closes #128
@Mte90

Mte90 commented Jul 20, 2018

Copy link
Copy Markdown
Contributor Author

Do we need a behat test for that?
@Mte90

Mte90 commented Jul 20, 2018

Copy link
Copy Markdown
Contributor Author

From what I can see in post.feature there are post id but there is no way to detect the post type itself so I am not sure what to do for that part.
@Mte90

Mte90 commented Jul 20, 2018

Copy link
Copy Markdown
Contributor Author

The tests are failing on the case of force and I don't understand why it's happening.
When I tried the command on a site was working, if someone can help on that will be appreciated :-)
@Mte90

Mte90 commented Dec 12, 2018

Copy link
Copy Markdown
Contributor Author

thanks for the help!
@schlessera

schlessera commented Dec 12, 2018

Copy link
Copy Markdown
Member

I had trouble figuring out what the actual problem was... until I noticed that the failure came from a different test and it was just because the tests were running out of order.
@schlessera schlessera added the command:post-delete Related to 'post delete' command label Dec 12, 2018
@schlessera schlessera added this to the 2.0.2 milestone Dec 12, 2018
@schlessera
schlessera merged commit 459fba6 into wp-cli:master Dec 12, 2018
@schlessera schlessera changed the title Delete alert in case of custom post type Dec 12, 2018
@ocean90 ocean90 mentioned this pull request May 12, 2020
Closed
Copilot AI mentioned this pull request Nov 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command:post-delete Related to 'post delete' command

2 participants

@Mte90 @schlessera