Add --slug=<site> as an available parameter to wp site commands

[tubiz]

Fixes #257

Slug has been added as an available parameter for the wp site commands listed below

• archive wp site archive --slug={siteslug}
• activate wp site activate --slug={siteslug}
• deactivate wp site deactivate --slug={siteslug}
• mature wp site mature --slug={siteslug}
• private wp site private --slug={siteslug}
• public wp site public --slug={siteslug}
• spam wp site spam --slug={siteslug}
• unarchive wp site unarchive --slug={siteslug}
• unmature wp site unmature --slug={siteslug}
• unspam wp site unspam --slug={siteslug}

Related wp-cli/wp-cli#5832

[schlessera]

Great work so far, @tubiz !

Are you still up for adding feature tests for this?

[tubiz]

Great work so far, @tubiz !

Are you still up for adding feature tests for this?

Yes. I will get started with adding the feature tests.

[danielbachhuber]

Can we include some tests covering this change? Also, it'd be great to abstract the site fetcher to a dedicated method.

[danielbachhuber]

Getting better! I think there's just one last bit to address.

[danielbachhuber]

For all of these, we also need to provide some error mechanism when neither <id> nor --slug= are provided. Check out wp plugin activate and its sibling commands for an example of how this can be implemented:

https://github.com/wp-cli/extension-command/blob/6a68d247969b8968b007a4d664e0de14bf69e775/src/Plugin_Command.php#L317-L320
https://github.com/wp-cli/extension-command/blob/6a68d247969b8968b007a4d664e0de14bf69e775/src/WP_CLI/ParsePluginNameInput.php#L9-L47

We'll want to add tests for this aspect too.

Your get_site_by_slug() method could be updated to $this->get_sites( $args, $assoc_args ) and return a $blogs variable that's passed directly into $this->update_site_status()

[tubiz]

Update get_site_by_slug() method to get_sites_ids()

The check to ensure that the site IDs or slug are provided is now done in the check_site_ids_and_slug() method.

[danielbachhuber]

Thanks for your work on this, @tubiz !

I made one more tweak with 24d2cbe