Skip to content

Add title/description for mu-plugins. - #305

Merged
swissspidy merged 9 commits into
wp-cli:masterfrom
alexstine:add/mu-plugin-title
May 25, 2022
Merged

Add title/description for mu-plugins.#305
swissspidy merged 9 commits into
wp-cli:masterfrom
alexstine:add/mu-plugin-title

Conversation

@alexstine

@alexstine alexstine commented Nov 18, 2021

Copy link
Copy Markdown
Contributor

Currently, only name is populated for mu-plugins. This PR will also fill in the title and add the description.

@alexstine
alexstine requested a review from a team as a code owner November 18, 2021 21:07
@schlessera

Copy link
Copy Markdown
Member

Thanks for the PR, @alexstine !

The code looks good at first glance, but to merge it, we'd need a Behat test as well to ensure it actually does (and keeps doing) what it is supposed to do. Do you care to add such a test?

@alexstine

Copy link
Copy Markdown
Contributor Author

@schlessera Can you find another contributor to implement the test? I just don't have time at the moment and I'm sure you are probably in the same boat. Maybe one for next CLI meeting?

Thanks.

@wojsmol

wojsmol commented May 12, 2022

Copy link
Copy Markdown
Contributor

@alexstine Changes reverted in 10b75d3 was correct.

@alexstine

Copy link
Copy Markdown
Contributor Author

@wojsmol Better now? Just refreshed the fork/branch.

@wojsmol

wojsmol commented May 12, 2022

Copy link
Copy Markdown
Contributor

@alexstine LGTM now. Tests are requiring @schlessera approval to run.

@alexstine

Copy link
Copy Markdown
Contributor Author

@wojsmol These check fails don't look related to my changes. Maybe worth a re-run?

@swissspidy

Copy link
Copy Markdown
Member

Should we also add support for descriptions?

Tests are all passing now btw

@alexstine

Copy link
Copy Markdown
Contributor Author

Nothing like all green checks. 👍

If you think it is a good idea, I can try to get descriptions working or can handle in another PR.

@swissspidy

Copy link
Copy Markdown
Member

If you're up for it, that would be great. Can be in this PR or a new one, whatever works best for you. Code-wise it should be mostly copy & paste

@alexstine alexstine changed the title Add title for mu-plugins. May 25, 2022
@alexstine

Copy link
Copy Markdown
Contributor Author

@swissspidy Done. Not sure if the tests will pass but hopefully so. Gave this a test on my test server, seems solid enough.

Comment thread features/plugin.feature Outdated
@swissspidy swissspidy added this to the 2.1.5 milestone May 25, 2022
@swissspidy
swissspidy merged commit 68f1fcf into wp-cli:master May 25, 2022
@alexstine
alexstine deleted the add/mu-plugin-title branch May 27, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants