Added Extra instructions to override the DB test credentials. - #410
Merged
Conversation
Closed
2 tasks
Member
|
Yes, indeed, I have to look them up as well. Maybe we can print a helpful screen when the database connection fails here? |
schlessera
approved these changes
May 30, 2022
schlessera
requested changes
May 30, 2022
schlessera
approved these changes
May 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every time I have to refesh my setup and try the tests I always have to lookup these DB instructions again..
Might be worth discussing to move it in a config file.
But this will at least help a bit.