Skip to content

Fix unclosed quote - #350

Merged
danielbachhuber merged 1 commit into
wp-cli:mainfrom
cliffordp:patch-1
Feb 2, 2023
Merged

Fix unclosed quote#350
danielbachhuber merged 1 commit into
wp-cli:mainfrom
cliffordp:patch-1

Conversation

@cliffordp

Copy link
Copy Markdown
Contributor

Not sure if it requires being surrounded by quotes so PR might need an adjustment in the other direction

Not sure if it requires being surrounded by quotes so PR might need an adjustment in the other direction
@cliffordp
cliffordp requested a review from a team as a code owner February 2, 2023 23:10

@danielbachhuber danielbachhuber left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works fine without the quote. Thanks @cliffordp !

@danielbachhuber danielbachhuber added this to the 2.4.1 milestone Feb 2, 2023
@danielbachhuber danielbachhuber added the scope:documentation Related to documentation label Feb 2, 2023
@danielbachhuber danielbachhuber modified the milestones: 2.4.1, 2.4.2 Feb 2, 2023
@danielbachhuber
danielbachhuber merged commit 5ff22bf into wp-cli:main Feb 2, 2023
@swissspidy

swissspidy commented Feb 2, 2023

Copy link
Copy Markdown
Member

@danielbachhuber @cliffordp the readme is generated from the source code, so it needs to be fixed there instead. otherwise the change gets overriddem with the next sync

@danielbachhuber

Copy link
Copy Markdown
Member

@swissspidy Oops, I thought this was a change to the command. I've updated the command with 9d09e90

Thanks for the catch!

@cliffordp
cliffordp deleted the patch-1 branch February 3, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:documentation Related to documentation

3 participants