Skip to content

Allow for diverging PHPUnit version specifics in tests #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schlessera merged 8 commits into from
Jan 25, 2022
Merged

Allow for diverging PHPUnit version specifics in tests #304

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b120c8b
Allow for diverging PHPUnit version specifics in tests
schlessera Jan 25, 2022
04119db
Remove version-specific branches in tests
schlessera Jan 25, 2022
65dcbf8
Point to polyfils for running tests
schlessera Jan 25, 2022
c2a0b48
Create polyfills directory before composer init
schlessera Jan 25, 2022
7e4bb3e
Avoid output from Composer
schlessera Jan 25, 2022
f5a1f10
Fix typo in polyfills path
schlessera Jan 25, 2022
09254cd
Revert "Remove version-specific branches in tests"
schlessera Jan 25, 2022
8bbab06
Adapt tests for PHP 8.0+
schlessera Jan 25, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions features/install-wp-tests.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Feature: Scaffold install-wp-tests.sh tests
"""
And the return code should be 1

@require-php-5.6 @less-than-php-8.0
@less-than-php-8.0
Scenario: Install latest version of WordPress
Given a WP install
And a affirmative-response file:
Expand Down Expand Up @@ -102,7 +102,13 @@ Feature: Scaffold install-wp-tests.sh tests
wp_cli_test_scaffold
"""

When I run `WP_TESTS_DIR={RUN_DIR}/wordpress-tests-lib ./phpunit -c {PLUGIN_DIR}/hello-world/phpunit.xml.dist`
When I run `mkdir polyfills && composer init --name=test/package --require="yoast/phpunit-polyfills:^1" --no-interaction --quiet --working-dir=polyfills`
Then the return code should be 0

When I run `composer install --no-interaction --working-dir=polyfills --quiet`
Then the return code should be 0

When I run `WP_TESTS_DIR={RUN_DIR}/wordpress-tests-lib WP_TESTS_PHPUNIT_POLYFILLS_PATH={RUN_DIR}/polyfills/vendor/yoast/phpunit-polyfills ./phpunit -c {PLUGIN_DIR}/hello-world/phpunit.xml.dist`
Then the return code should be 0

When I try `WP_TESTS_DIR={RUN_DIR}/wordpress-tests-lib WP_CORE_DIR={RUN_DIR}/wordpress /usr/bin/env bash {PLUGIN_DIR}/hello-world/bin/install-wp-tests.sh wp_cli_test_scaffold {DB_USER} {DB_PASSWORD} {DB_HOST} latest < affirmative-response`
Expand Down Expand Up @@ -215,11 +221,25 @@ Feature: Scaffold install-wp-tests.sh tests
wp_cli_test_scaffold
"""

When I try `WP_TESTS_DIR={RUN_DIR}/wordpress-tests-lib ./phpunit -c {PLUGIN_DIR}/hello-world/phpunit.xml.dist`
When I run `mkdir polyfills && composer init --name=test/package --require="yoast/phpunit-polyfills:^1" --no-interaction --quiet --working-dir=polyfills`
Then the return code should be 0

When I run `composer install --no-interaction --working-dir=polyfills --quiet`
Then the return code should be 0

When I try `WP_TESTS_DIR={RUN_DIR}/wordpress-tests-lib WP_TESTS_PHPUNIT_POLYFILLS_PATH={RUN_DIR}/polyfills/vendor/yoast/phpunit-polyfills ./phpunit -c {PLUGIN_DIR}/hello-world/phpunit.xml.dist`
Then the return code should be 1
And STDOUT should contain:
"""
Looks like you're using PHPUnit 9.5.8. WordPress requires at least PHPUnit 5.4 and is currently only compatible with PHPUnit up to 7.x.
Looks like you're using PHPUnit 9.5.
"""
And STDOUT should contain:
"""
WordPress requires at least PHPUnit 5.
"""
And STDOUT should contain:
"""
and is currently only compatible with PHPUnit up to 7.x.
"""

When I try `WP_TESTS_DIR={RUN_DIR}/wordpress-tests-lib WP_CORE_DIR={RUN_DIR}/wordpress /usr/bin/env bash {PLUGIN_DIR}/hello-world/bin/install-wp-tests.sh wp_cli_test_scaffold {DB_USER} {DB_PASSWORD} {DB_HOST} latest < affirmative-response`
Expand Down