Skip to content

Remove grunt from plugin scaffolding - #337

Merged
swissspidy merged 4 commits into
wp-cli:mainfrom
ernilambar:140-remove-grunt
Jan 29, 2025
Merged

Remove grunt from plugin scaffolding#337
swissspidy merged 4 commits into
wp-cli:mainfrom
ernilambar:140-remove-grunt

Conversation

@ernilambar

@ernilambar ernilambar commented May 9, 2024

Copy link
Copy Markdown
Member

Fixes #140

  • plugin-gruntfile.mustache is removed.
  • plugin-packages.mustache is removed.
  • plugin-composer.mustache is added.
  • vendor/ is added in plugin-gitignore.mustache
  • In composer wp-cli/i18n-command package is added. Script makepot is kept to generate POT file so that user can generate POT file like this command composer run makepot
@ernilambar
ernilambar marked this pull request as ready for review May 9, 2024 05:52
@ernilambar
ernilambar requested a review from a team as a code owner May 9, 2024 05:52
Comment thread templates/plugin-composer.mustache Outdated
Co-authored-by: Pascal Birchler <pascal.birchler@gmail.com>
@ernilambar

Copy link
Copy Markdown
Member Author

@swissspidy I am not finding button or link to re-run tests for this PR. Any idea? :-)

@swissspidy

Copy link
Copy Markdown
Member

I think the button disappears after a 90 days or so (when the logs are deleted). So simply make a change (e.g. merge in the main branch or so) to trigger tests again :)

By the way, I just had a look at this again and I think in favor of the addtextdomain task we could install WPCS via Composer. What do you think? Probably for a follow-up PR though, so we can get the config right.

@ernilambar

Copy link
Copy Markdown
Member Author

You mean like this in ruleset?

<rule ref="WordPress.Utils.I18nTextDomainFixer">
   <properties>
      <property name="old_text_domain" type="array">
         <element value="" />
      </property>
      <property name="new_text_domain" value="plugin-slug" />
   </properties>
</rule>
@swissspidy

Copy link
Copy Markdown
Member

Yeah, although that requires old_text_domain to be set for some reason, so maybe not great. So let's forget this for now :-) You don't really need it in a newly scaffolded plugin anyway.

I see we actually have templates/.phpcs.xml.dist already, so installing PHPCS via Composer would be good thing for a next PR though.

@swissspidy swissspidy added this to the 2.5.0 milestone Jan 29, 2025
@swissspidy
swissspidy merged commit e706981 into wp-cli:main Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants