Skip to content

Add LD_RUNPATH_SEARCH_PATHS to extensionkit-extension preset#1255

Open
alessionossa wants to merge 1 commit into
yonaskolb:masterfrom
alessionossa:patch-1
Open

Add LD_RUNPATH_SEARCH_PATHS to extensionkit-extension preset#1255
alessionossa wants to merge 1 commit into
yonaskolb:masterfrom
alessionossa:patch-1

Conversation

@alessionossa

Copy link
Copy Markdown

Add LD_RUNPATH_SEARCH_PATHS option as it is for other types of extensions (e.g. app extension).
I followed the same logic of #272, copying the value from the current version of SettingPresets/Products/app-extension.yml

@freddi-kit

Copy link
Copy Markdown
Collaborator

I started thinking it also should be fixed by XcodeProj (yes, this pr also should be okay), could you check it if you have time?

https://github.com/tuist/XcodeProj/blob/b6de1bfe021b861c94e7c83821b595083f74b997/Sources/XcodeProj/Utils/BuildSettingsProvider.swift#L224-L229

@freddi-kit freddi-kit requested a review from yonaskolb September 6, 2022 02:29
@alessionossa

alessionossa commented Sep 6, 2022

Copy link
Copy Markdown
Author

I started thinking it also should be fixed by XcodeProj (yes, this pr also should be okay), could you check it if you have time?

https://github.com/tuist/XcodeProj/blob/b6de1bfe021b861c94e7c83821b595083f74b997/Sources/XcodeProj/Utils/BuildSettingsProvider.swift#L224-L229

@freddi-kit I see that targetSettings(platform:, product:) is only called by targetDefault(variant:, platform:, product:, swift:) and we are not calling the latter method anywhere. Are you think of using that instead of "custom overrides"?

@yonaskolb

Copy link
Copy Markdown
Owner

Thanks @alessionossa. Could you add a changelog entry as well please.

And at the moment we aren't using the BuildSettingsProvider from XcodeProj, as that didn't exist at the time. I've created a new issue to track that here #1267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants