gpui: Fix text wrapping for URLs #35724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
Contributor
Author
After change in Zed:
|
Member
|
Thank you! |
auto-merge was automatically disabled
October 16, 2025 01:44
Head branch was pushed to by a user without write access
Contributor
Author
|
The test has failed, caused by 605af7d changed I have reverted to last version. |
P1n3appl3
pushed a commit
to P1n3appl3/zed
that referenced
this pull request
Oct 18, 2025
Close zed-industries#35715 Release Notes: - Fixed to wrap long URLs in editor. <img width="836" height="740" alt="image" src="https://github.com/user-attachments/assets/635ce792-5f19-4c76-b131-0d270d09b103" /> I remember when I was working on CJK line wrapping support in the early days, I considered making `\` a line wrapping character, but for some reason it was on the list of characters that were not allowed to wrap. In reference to VS Code, it looks like `&`, `/`, `?` should wrap, so I removed all of them. --------- Co-authored-by: Mikayla Maki <mikayla@zed.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #35715
Release Notes:
I remember when I was working on CJK line wrapping support in the early days, I considered making
\a line wrapping character, but for some reason it was on the list of characters that were not allowed to wrap.In reference to VS Code, it looks like
&,/,?should wrap, so I removed all of them.