Skip to content

themes: Improve Gruvbox scrollbar colors #38145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danilo-leal merged 3 commits into from
Oct 21, 2025
Merged

themes: Improve Gruvbox scrollbar colors #38145

danilo-leal merged 3 commits into from
Oct 21, 2025

Conversation

@dangooddd
Copy link
Contributor

@dangooddd dangooddd commented Sep 14, 2025 •
edited
Loading

Changes that I made:

  • add "scrollbar.thumb.active_background" to all themes
  • for dark themes: scrollbar.thumb.background is darker than hover (fg4 from palette for background and fg0 for hover)
  • for light themes: scrollbar.thumb.background is lighter than hover (fg4 for background and fg0 for hover like in dark theme case)

Those changes is consistent with VSCode gruvbox theme and other applications.
For active_background I chose orange color, but we can use cyan color to match vscode theme.

UPDATE: decided to use blue for active scrollbar as this color is used as accent in other parts of gruvbox themes

Release Notes:

  • Improved scrollbar colors for Gruvbox theme
@cla-bot

This comment was marked as resolved.

Sign in to view
@dangooddd

This comment was marked as resolved.

Sign in to view
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Sep 14, 2025
@cla-bot

This comment was marked as resolved.

Sign in to view
@maxdeviant maxdeviant changed the title theme: improve gruvbox scrollbar behaviour/colors Sep 14, 2025
@dangooddd
Copy link
Contributor Author

dangooddd commented Sep 14, 2025 •
edited by notpeter
Loading

Here is comparison in following order:
rest -> hover -> active

Before After
image image
@danilo-leal danilo-leal self-assigned this Sep 15, 2025
@notpeter notpeter added the area:design papercut Small visual defects label Sep 17, 2025
@dangooddd
Copy link
Contributor Author

dangooddd commented Sep 19, 2025

Any opinions or updates on this? I am open to discussion!
danilo-leal
danilo-leal approved these changes Oct 20, 2025
View reviewed changes
Copy link
Member

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! Apologies for the delayed review here.
@danilo-leal danilo-leal merged commit 62516e8 into zed-industries:main Oct 21, 2025
21 checks passed
@dangooddd
Copy link
Contributor Author

dangooddd commented Oct 21, 2025

Thank you for your work!
@dangooddd
Copy link
Contributor Author

dangooddd commented Oct 21, 2025

Would you like if I open similar PRs for other default themes? @danilo-leal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:design papercut Small visual defects cla-signed The user has signed the Contributor License Agreement

3 participants

@dangooddd @danilo-leal @notpeter