ollama: Add button for refreshing available models #38181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
Contributor
Author
|
Another approach would be to update models everytime the menu is opened. However the Only fetching capabilities for new models is likely something we want to implement regardless, but I can include it here incase we want to take the "fetch on every open" approach. |
MrSubidubi
added
the
area:ai
bennetbo
approved these changes
Oct 31, 2025
Member
bennetbo
left a comment
bennetbo
left a comment
There was a problem hiding this comment.
Thank you! I think this is good to get in, even though there might be more elegant solutions to this.
tomatitito
pushed a commit
to tomatitito/zed
that referenced
this pull request
Nov 7, 2025
) Closes zed-industries#17524 This PR adds a button to the bottom right corner of the ollama settings ui. It resets the available ollama models, also resets the "Connected" state in the process. This means it can be used to check if the connection is still valid as well. It's a question whether we should clear the available models on ALL `fetch_models` calls, since these only happen during auth anyway. Ollama is a local model provider which means clicking the refresh button often only flashes the "not connected" state because the latency of the request is so low. This accentuates changes in the UI, however I don't think there's a way around this without adding some rather cumbersome deferred ui updates. I've attached the refresh button to the "Connected" `ButtonLike`, since I don't think automatic UI spacing should separate these elements. I think this is okay because the "Connected" isn't actually something that the user can interact with. Before: <img width="211" height="245" alt="image" src="https://github.com/user-attachments/assets/ea90e24a-b603-4ee2-9212-2917e1695774" /> After: <img width="211" height="250" alt="image" src="https://github.com/user-attachments/assets/be9af950-86a2-4067-87a0-52034a80a823" /> Alternative approach: There was also a suggestion to simply add a entry to the command palette, however none of the other providers have this ability currently either so I went with this approach. The current approach also makes it more discoverable to the user. Release Notes: - Added a button for refreshing available ollama models --------- Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17524
This PR adds a button to the bottom right corner of the ollama settings ui. It resets the available ollama models, also resets the "Connected" state in the process. This means it can be used to check if the connection is still valid as well. It's a question whether we should clear the available models on ALL
fetch_modelscalls, since these only happen during auth anyway.Ollama is a local model provider which means clicking the refresh button often only flashes the "not connected" state because the latency of the request is so low. This accentuates changes in the UI, however I don't think there's a way around this without adding some rather cumbersome deferred ui updates.
I've attached the refresh button to the "Connected"
ButtonLike, since I don't think automatic UI spacing should separate these elements. I think this is okay because the "Connected" isn't actually something that the user can interact with.Before:
After:
Alternative approach: There was also a suggestion to simply add a entry to the command palette, however none of the other providers have this ability currently either so I went with this approach. The current approach also makes it more discoverable to the user.
Release Notes: