Fix floating file chooser

[AlvaroParker]

Closes #39117

Some window managers (example: hyprland hyprwm/Hyprland#11229) still won't open a floating file chooser because they don't support the XDG foreign protocol yet: https://wayland.app/protocols/xdg-foreign-unstable-v2

Release Notes:

• Fixed file chooser not floating

[zed-industries-bot]

	Messages
📖	This PR includes links to the following GitHub Issues: #hyprwm/Hyprland#11229 If this PR aims to close an issue, please include a Closes #ISSUE line at the top of the PR body.

Generated by 🚫 dangerJS against 3948250

[JosephTLyons]

Thanks for the PR @AlvaroParker - we'll get to a review ASAP!

[yara-blue]

Thanks for the PR @AlvaroParker - we'll get to a review ASAP!

Was reviewing this last week. It seems to be great. I'm a little unsure about returning the oneshot is the best way to approach. Should we return a future? or make the member acync?

[AlvaroParker]

Maybe using BoxFuture is a better aproach?
If we make the member function async instead, we wouldn't be able to await it inside the task on the foreground executor because the return type doesn't implement Send

[yara-blue]

we wouldn't be able to await it inside the task on the foreground executor because the return type doesn't implement Send

Then we just make it send :)

I've gone ahead and done so over here: main...send-WindowIdentifier-futures

Its a tweak upon this PR. If your okay with it I'll close this and squash merge.

[AlvaroParker]

Sure!

[yara-blue]

Sure!

On second thought, if I do that your no longer the author but a co-author. That feels wrong to me. Could you pull in the changes from that branch into this PR? Then I can merge it with you as primary author as it should be.

[AlvaroParker]

Done, thanks!