Skip to content

settings: Flatten code actions formatters object #39375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
probably-neb merged 5 commits into from
Oct 2, 2025
Merged

settings: Flatten code actions formatters object #39375

probably-neb merged 5 commits into from
Oct 2, 2025

Conversation

@probably-neb
Copy link
Collaborator

@probably-neb probably-neb commented Oct 2, 2025 •
edited
Loading

Closes #ISSUE

Release Notes:

  • settings: Changed code action format in formatter and format_on_save settings.

Previous format:

{
  "code_actions": {
    "source.organizeImports": true,
    "source.fixAll": true
  }
}

New format:

[
  {"code_action": "source.organizeImports"},
  {"code_action": "source.fixAll"}
]

After #39246, code actions run sequentially in order. The structure now reflects this and aligns with other formatter options (e.g., language servers).

Both the formatter and format_on_save settings will be auto-migrated.
@probably-neb probably-neb enabled auto-merge (squash) October 2, 2025 14:44
@probably-neb probably-neb merged commit 6fbbdb3 into main Oct 2, 2025
23 checks passed
@probably-neb probably-neb deleted the flatten-code-actions-formatters branch October 2, 2025 14:48
LivioGama pushed a commit to LivioGama/zed that referenced this pull request Oct 11, 2025
@probably-neb @LivioGama
settings: Flatten code actions formatters object (zed-industries#39375)
62083fd 
Closes #ISSUE

Release Notes:

- settings: Changed code action format in `formatter` and
`format_on_save` settings.

**Previous format:**
```
{
  "code_actions": {
    "source.organizeImports": true,
    "source.fixAll": true
  }
}
```

**New format:**
```
[
  {"code_action": "source.organizeImports"},
  {"code_action": "source.fixAll"}
]
```

After zed-industries#39246, code actions run sequentially in order. The structure now
reflects this and aligns with other formatter options (e.g., language
servers).

Both the `formatter` and `format_on_save` settings will be
auto-migrated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@probably-neb