agent2: Expand auto-retries for completion errors #39787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: David Kleingeld <davidsk@zed.dev>
Co-authored-by: David Kleingeld <davidsk@zed.dev>
cla-bot
bot
added
the
cla-signed
maxdeviant
commented
Oct 8, 2025
| .await | ||
| .map_err(|error| anyhow!(error))?; | ||
|
|
||
| let (mut events, mut error) = match model.stream_completion(request, cx).await { |
Member
Author
There was a problem hiding this comment.
@dvdsk and I noticed that the error handling in this could be improved, as right now the success path and error path are somewhat intertwined (e.g., using the emptiness of events/tool_results for control flow).
This could probably benefit from a larger refactoring in order to make the control flow clearer, but we didn't want to touch it as part of this change on account of not being super familiar with this code.
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Oct 11, 2025
This PR expands our automatic retry behavior for certain classes of completion errors (e.g., rate limit errors). Previously this was only available when using burn mode. We now auto-retry when: - Using the Zed provider while on a token-based plan - Using the Zed provider while on a legacy plan with burn mode enabled - Using a non-Zed provider Release Notes: - Expanded automatic retry behavior for errors in the Agent. Errors classified as "retryable" (such as rate limit errors) will now automatically be retried when: - Using the Zed provider while on a token-based plan - Using the Zed provider while on a legacy plan with burn mode enabled - Using a non-Zed provider --------- Co-authored-by: David Kleingeld <davidsk@zed.dev>
Contributor
|
@maxdeviant thank you! I noticed Zed retrying and found this in the release notes. This is a big time saver for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands our automatic retry behavior for certain classes of completion errors (e.g., rate limit errors).
Previously this was only available when using burn mode.
We now auto-retry when:
Release Notes: