ollama: Resolve context window size via API #39941
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were guessing the context window size here:
zed/crates/ollama/src/ollama.rs
Line 22 in 8c3f09e
This is inaccurate and must be updated manually. This PR ensures that we extract the context window size from the request in the same way that the Ollama CLI does when running
ollama show <model-name>(Relevant code is here)The format looks like this:
{ "model_info": { "general.architecture": "llama", "llama.context_length": 132000 } }Once this PR is merged we could technically remove the old code
zed/crates/ollama/src/ollama.rs
Line 22 in 8c3f09e
I decided to keep it for now, as it is unclear if the necessary fields are available via the API on older Ollama versions.
Release Notes: