Skip to content

Conversation

@bobbymannino
Copy link
Contributor

@bobbymannino bobbymannino commented Oct 17, 2025

Closes discussion #28943

Release Notes:

  • Added: center_on_match option for centering cursor on buffer/project search
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Oct 17, 2025
@github-actions github-actions bot added the community champion Issues filed by our amazing community champions! 🫶 label Oct 17, 2025
@maxdeviant maxdeviant changed the title feat: add in center on search option Oct 17, 2025
@smitbarmase smitbarmase self-assigned this Oct 20, 2025
@JosephTLyons
Copy link
Collaborator

Thanks for opening a PR @bobbymannino - we'll take a look soon!

Copy link
Member

@smitbarmase smitbarmase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add this setting for the settings UI?

@bobbymannino
Copy link
Contributor Author

@smitbarmase should be done now

Copy link
Member

@smitbarmase smitbarmase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great. I noticed that this works in buffer search but not in project search. We should make it work for project search too.

@bobbymannino
Copy link
Contributor Author

nice, ill take a look today at some point

@bobbymannino
Copy link
Contributor Author

Copy link
Member

@smitbarmase smitbarmase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@smitbarmase smitbarmase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix CI errors? You can run them locally using ./script/clippy and cargo nextest run --workspace --no-fail-fast.

@bobbymannino
Copy link
Contributor Author

fixed the issues i think, but im getting 25 errors to do with postgres? not sure if they're my doing?

Summary [ 278.079s] 2901 tests run: 2876 passed, 25 failed, 36 skipped
        FAIL [   0.316s] collab db::tests::buffer_tests::test_channel_buffers_last_operations_postgres
        FAIL [   0.185s] collab db::tests::buffer_tests::test_channel_buffers_postgres
        FAIL [   0.174s] collab db::tests::channel_tests::test_channel_invites_postgres
        FAIL [   0.181s] collab db::tests::channel_tests::test_channel_renames_postgres
        FAIL [   0.209s] collab db::tests::channel_tests::test_channel_reordering_postgres
        FAIL [   0.199s] collab db::tests::channel_tests::test_channels_postgres
        FAIL [   0.222s] collab db::tests::channel_tests::test_db_channel_moving_bugs_postgres
        FAIL [   0.239s] collab db::tests::channel_tests::test_db_channel_moving_postgres
        FAIL [   0.220s] collab db::tests::channel_tests::test_joining_channels_postgres
        FAIL [   0.204s] collab db::tests::channel_tests::test_user_is_channel_participant_postgres
        FAIL [   0.246s] collab db::tests::contributor_tests::test_contributors_postgres
        FAIL [   0.178s] collab db::tests::db_tests::test_add_contacts_postgres
        FAIL [   0.182s] collab db::tests::db_tests::test_create_access_tokens_postgres
        FAIL [   0.188s] collab db::tests::db_tests::test_fuzzy_search_users
        FAIL [   0.212s] collab db::tests::db_tests::test_get_users_by_ids_postgres
        FAIL [   0.195s] collab db::tests::db_tests::test_metrics_id_postgres
        FAIL [   0.181s] collab db::tests::db_tests::test_project_count_postgres
        FAIL [   0.183s] collab db::tests::db_tests::test_update_or_create_user_by_github_account_postgres
        FAIL [   0.198s] collab db::tests::embedding_tests::test_get_embeddings_postgres
        FAIL [   0.190s] collab db::tests::embedding_tests::test_purge_old_embeddings
        FAIL [   0.210s] collab db::tests::extension_tests::test_extensions_by_id_postgres
        FAIL [   0.193s] collab db::tests::extension_tests::test_extensions_postgres
        FAIL [   0.219s] collab db::tests::user_tests::test_accepted_tos_postgres
        FAIL [   0.204s] collab db::tests::user_tests::test_destroy_user_cascade_deletes_access_tokens_postgres
        FAIL [   0.573s] terminal tests::test_terminal_no_exit_on_spawn_failure
@smitbarmase smitbarmase force-pushed the feat/center-on-search-option branch from 18efecf to c639b4d Compare November 3, 2025 14:38
@smitbarmase smitbarmase merged commit 2131d88 into zed-industries:main Nov 3, 2025
37 of 39 checks passed
@smitbarmase
Copy link
Member

Thank you!

Tip for next time, please resolve CI issues by running ./script/clippy and crate specific tests using the -p flag. That way, you don't have to deal with other unrelated tests failing, such as collab.

P1n3appl3 pushed a commit to bnjjj/zed that referenced this pull request Nov 4, 2025
[Closes discussion
zed-industries#28943](zed-industries#28943)

Release Notes:

- Added `center_on_match` option to center matched text in view during buffer or project search.

---------

Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
tomatitito pushed a commit to tomatitito/zed that referenced this pull request Nov 7, 2025
[Closes discussion
zed-industries#28943](zed-industries#28943)

Release Notes:

- Added `center_on_match` option to center matched text in view during buffer or project search.

---------

Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement community champion Issues filed by our amazing community champions! 🫶

3 participants