-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Add center_on_match option for search
#40523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add center_on_match option for search
#40523
Conversation
|
Thanks for opening a PR @bobbymannino - we'll take a look soon! |
smitbarmase
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add this setting for the settings UI?
|
@smitbarmase should be done now |
smitbarmase
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks great. I noticed that this works in buffer search but not in project search. We should make it work for project search too.
|
nice, ill take a look today at some point |
|
@smitbarmase done |
smitbarmase
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
smitbarmase
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix CI errors? You can run them locally using ./script/clippy and cargo nextest run --workspace --no-fail-fast.
|
fixed the issues i think, but im getting 25 errors to do with postgres? not sure if they're my doing? |
18efecf to
c639b4d
Compare
|
Thank you! Tip for next time, please resolve CI issues by running |
[Closes discussion zed-industries#28943](zed-industries#28943) Release Notes: - Added `center_on_match` option to center matched text in view during buffer or project search. --------- Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
[Closes discussion zed-industries#28943](zed-industries#28943) Release Notes: - Added `center_on_match` option to center matched text in view during buffer or project search. --------- Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
Closes discussion #28943
Release Notes:
center_on_matchoption for centering cursor on buffer/project search