-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
agent_ui: Insert thread summary as proper mention URI #40722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
agent_ui: Insert thread summary as proper mention URI #40722
Conversation
|
It's not clear to me how it would solve the issue the user reported. The current format should be the same as after this PR? Can you give some more details? |
|
@bennetbo I dont think this should be closed without reconsidering that every other place in the code inserts mentions as link, but only summary is being inserted as title, this PR fixes it. |
|
Looking at it again your change makes sense to get in. However, I don't see how it would fix the bug that was reported in #38292, since this PR does not change anything of how we include a summary. Correct me if I'm missing anything. |
|
@bennetbo thanks, I've redacted description, I will also handle merge conflicts. I am also unable to reproduce original issue regarding #38292 but I am definitely able to reproduce issue with copy-pasting mention that this PR fixes following video shows whats impossible right now on upstream branch Screen.Recording.2025-10-30.at.02.15.32.mov |
50b4de8 to
3ee4f09
Compare
3ee4f09 to
37b6520
Compare
|
@bennetbo I've addressed the failure on windows/linux which seems not include initiation LSP fake server, I'm adding init harness only to my test but if you recommend to move this into cx.update(LanguageModelRegistry::test); |
bennetbo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
…#40722) This ensures the thread summary is treated as a tracked mention with accessible context. Changes: - Fixed `MessageEditor::insert_thread_summary()` to use proper mention URI format - Added test coverage to verify the fix Release Notes: - Fixed an issue where "New From Summary" was not properly inserting thread summaries as contextual mentions when creating new threads. Thread summaries are now inserted as proper mention URIs.
This ensures the thread summary is treated as a tracked mention with accessible context.
Changes:
MessageEditor::insert_thread_summary()to use proper mention URI formatRelease Notes: