Skip to content

Conversation

@pkondzior
Copy link
Contributor

@pkondzior pkondzior commented Oct 20, 2025

This ensures the thread summary is treated as a tracked mention with accessible context.

Changes:

  • Fixed MessageEditor::insert_thread_summary() to use proper mention URI format
  • Added test coverage to verify the fix

Release Notes:

  • Fixed an issue where "New From Summary" was not properly inserting thread summaries as contextual mentions when creating new threads. Thread summaries are now inserted as proper mention URIs.
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Oct 20, 2025
@pkondzior pkondzior marked this pull request as ready for review October 20, 2025 18:01
@maxdeviant maxdeviant changed the title agent_ai: Insert thread summary as proper mention uri Oct 20, 2025
@SomeoneToIgnore SomeoneToIgnore added the area:ai Improvement related to Agent Panel, Edit Prediction, Copilot, or other AI features label Oct 20, 2025
@bennetbo bennetbo self-assigned this Oct 27, 2025
@bennetbo bennetbo changed the title agent_ai: Insert thread summary as proper mention URI Oct 27, 2025
@bennetbo
Copy link
Member

It's not clear to me how it would solve the issue the user reported. The current format should be the same as after this PR? Can you give some more details?
On my end "New from summary" is working as expected

@bennetbo bennetbo closed this Oct 27, 2025
@pkondzior
Copy link
Contributor Author

@bennetbo I dont think this should be closed without reconsidering that every other place in the code inserts mentions as link, but only summary is being inserted as title, this PR fixes it.

@bennetbo
Copy link
Member

bennetbo commented Oct 29, 2025

Looking at it again your change makes sense to get in. However, I don't see how it would fix the bug that was reported in #38292, since this PR does not change anything of how we include a summary. Correct me if I'm missing anything.
Happy to merge this if the conflicts are fixed and we drop the Closes #38292.

@bennetbo bennetbo reopened this Oct 29, 2025
@pkondzior
Copy link
Contributor Author

pkondzior commented Oct 30, 2025

@bennetbo thanks, I've redacted description, I will also handle merge conflicts. I am also unable to reproduce original issue regarding #38292 but I am definitely able to reproduce issue with copy-pasting mention that this PR fixes following video shows whats impossible right now on upstream branch

Screen.Recording.2025-10-30.at.02.15.32.mov
@pkondzior pkondzior force-pushed the fix-bug-in-thread-from-summary-issue-38292 branch 2 times, most recently from 50b4de8 to 3ee4f09 Compare October 30, 2025 01:58
@pkondzior pkondzior force-pushed the fix-bug-in-thread-from-summary-issue-38292 branch from 3ee4f09 to 37b6520 Compare October 30, 2025 09:28
@pkondzior
Copy link
Contributor Author

@bennetbo I've addressed the failure on windows/linux which seems not include initiation LSP fake server, I'm adding init harness only to my test but if you recommend to move this into init_test I can do that

cx.update(LanguageModelRegistry::test);
Copy link
Member

@bennetbo bennetbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bennetbo bennetbo merged commit 7431803 into zed-industries:main Oct 30, 2025
24 checks passed
tomatitito pushed a commit to tomatitito/zed that referenced this pull request Nov 7, 2025
…#40722)

This ensures the thread summary is treated as a tracked mention with
accessible context.

Changes:
- Fixed `MessageEditor::insert_thread_summary()` to use proper mention
URI format
- Added test coverage to verify the fix

Release Notes:

- Fixed an issue where "New From Summary" was not properly inserting
thread summaries as contextual mentions when creating new threads.
Thread summaries are now inserted as proper mention URIs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:ai Improvement related to Agent Panel, Edit Prediction, Copilot, or other AI features cla-signed The user has signed the Contributor License Agreement

3 participants