Skip to content

Fix task terminal split #40824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SomeoneToIgnore merged 2 commits into from
Oct 21, 2025
Merged

Fix task terminal split #40824

SomeoneToIgnore merged 2 commits into from
Oct 21, 2025

Conversation

@SomeoneToIgnore
Copy link
Contributor

@SomeoneToIgnore SomeoneToIgnore commented Oct 21, 2025

Before:

before.mov

After:

after.mov

Release Notes:

  • Fixed task terminal split not working correctly
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Oct 21, 2025
@SomeoneToIgnore SomeoneToIgnore enabled auto-merge (squash) October 21, 2025 20:32
@SomeoneToIgnore SomeoneToIgnore merged commit 256fe6e into main Oct 21, 2025
21 checks passed
@SomeoneToIgnore SomeoneToIgnore deleted the kb/fix-task-split branch October 21, 2025 21:08
agu-z added a commit that referenced this pull request Oct 23, 2025
@agu-z
Revert "Fix task terminal split (#40824)"
5bb9a08 
This reverts commit 256fe6e.
@agu-z agu-z mentioned this pull request Oct 23, 2025
Merged
agu-z added a commit that referenced this pull request Oct 23, 2025
@agu-z
Revert: Spawn terminal process on background executor (#41060)
1cf765e 
Reverts #40774 and
#40824 since they introduce a
bug where Nushell processes are leaked and Ctrl+C doesn't kill the
current process.

Release Notes:

- Fix a bug where nushell processes wouldn't get killed after closing a
terminal tab
JosephTLyons pushed a commit that referenced this pull request Oct 24, 2025
@agu-z @JosephTLyons
Revert: Spawn terminal process on background executor (#41060)
08ba193 
Reverts #40774 and
#40824 since they introduce a
bug where Nushell processes are leaked and Ctrl+C doesn't kill the
current process.

Release Notes:

- Fix a bug where nushell processes wouldn't get killed after closing a
terminal tab
SomeoneToIgnore added a commit that referenced this pull request Oct 26, 2025
@SomeoneToIgnore
Fix task terminal split
408b195 
re-lands #40824
@SomeoneToIgnore SomeoneToIgnore mentioned this pull request Oct 26, 2025
Merged
SomeoneToIgnore added a commit that referenced this pull request Oct 26, 2025
@SomeoneToIgnore
Fix task terminal split (#41218)
54a7da3 
Re-lands #40824

Release Notes:

- N/A
tomatitito pushed a commit to tomatitito/zed that referenced this pull request Nov 7, 2025
@SomeoneToIgnore @tomatitito
Fix task terminal split (zed-industries#41218)
d2cf5d8 
Re-lands zed-industries#40824

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

2 participants

@SomeoneToIgnore