agent_ui: Show notifications also when the panel is hidden #40942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new setting, called notify_when_agent_is_hidden, that's disabled by default. It adds support for sending UI notifications when the agent panel is hidden. Currently Zed only displays agent notifications (e.g. when the agent completes a task) when the user switches apps. This adds additional messaging in the scenario that the agent finishes a long-running task and the user is busy coding within Zed on something else.
cla-bot
bot
added
the
cla-signed
maxdeviant
changed the title
Contributor
Author
|
Hello team, This is my first time authoring Rust and my first PR for Zed, so please let me know if there's any room for improvement here. It was composed by Claude (in Zed), so hopefully it looks good to you. |
danilo-leal
reviewed
Oct 23, 2025
Member
danilo-leal
left a comment
danilo-leal
left a comment
There was a problem hiding this comment.
Hey @cmclaughlin, thanks and congrats for the first PR; this is a super cool addition!
I actually think we can start out without having the setting and just follow the existing notify_when_agent_waiting one. Feels like it's a reasonable default; i.e., if the user has a non-null value for that setting, Zed would be notifying them if the app is either in the background or if the panel is hidden. IMO, we can test out simpler like this and re-evaluate the need for a setting later down the road.
SomeoneToIgnore
added
the
area:ai
Now the feature will work with the existing notify_when_agent_waiting setting
Contributor
Author
|
@danilo-leal thank you for the feedback. Would you please take another look? |
danilo-leal
approved these changes
Nov 1, 2025
This comment was marked as resolved.
This comment was marked as resolved.
danilo-leal
changed the title
scorphus
pushed a commit
to scorphus/zed
that referenced
this pull request
Nov 1, 2025
…tries#40942) Currently Zed only displays agent notifications (e.g. when the agent completes a task) if the user has switched apps and Zed is not in the foreground. This adds PR supports the scenario where the agent finishes a long-running task and the user is busy coding within Zed on something else. Releases Note: - If agent notifications are turned on, they will now also be displayed when the agent panel is hidden, in complement to them showing when the Zed window is in the background. --------- Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
tomatitito
pushed a commit
to tomatitito/zed
that referenced
this pull request
Nov 7, 2025
…tries#40942) Currently Zed only displays agent notifications (e.g. when the agent completes a task) if the user has switched apps and Zed is not in the foreground. This adds PR supports the scenario where the agent finishes a long-running task and the user is busy coding within Zed on something else. Releases Note: - If agent notifications are turned on, they will now also be displayed when the agent panel is hidden, in complement to them showing when the Zed window is in the background. --------- Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Zed only displays agent notifications (e.g. when the agent completes a task) if the user has switched apps and Zed is not in the foreground. This adds PR supports the scenario where the agent finishes a long-running task and the user is busy coding within Zed on something else.
Releases Note: