Skip to content

agent: Model name context #41490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rtfeldman merged 2 commits into from
Oct 31, 2025
Merged

agent: Model name context #41490

rtfeldman merged 2 commits into from
Oct 31, 2025

Conversation

@versecafe
Copy link
Contributor

@versecafe versecafe commented Oct 29, 2025

Closes #41478

Release Notes:

Screenshot 2025-10-29 at 1 31 26 PM

caused by using haiku 4.5 from the anthropic provider and then swapping to sonnet 3.7 through zed, doing this does mess with prompt caching but a model swap already invalidates that so it shouldn't have any cost impact on end users
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Oct 29, 2025
@github-actions github-actions bot added the community champion Issues filed by our amazing community champions! 🫶 label Oct 29, 2025
@JosephTLyons
Copy link
Collaborator

JosephTLyons commented Oct 30, 2025

Thanks again @versecafe, we'll review soon!
rtfeldman
rtfeldman approved these changes Oct 31, 2025
View reviewed changes
Copy link
Contributor

@rtfeldman rtfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems unlikely enough to cause a regression in evals that I'm happy to merge it and revert in the unlikely event that it causes a regression.

Thanks @versecafe! 🎉
@rtfeldman rtfeldman enabled auto-merge (squash) October 31, 2025 13:42
@rtfeldman rtfeldman merged commit c1dea84 into zed-industries:main Oct 31, 2025
24 checks passed
@versecafe versecafe mentioned this pull request Nov 3, 2025
Closed
tomatitito pushed a commit to tomatitito/zed that referenced this pull request Nov 7, 2025
@versecafe @tomatitito
agent: Model name context (zed-industries#41490)
6141e9d 
Closes zed-industries#41478

Release Notes:

- Fixed zed-industries#41478

<img width="459" height="916" alt="Screenshot 2025-10-29 at 1 31 26 PM"
src="https://github.com/user-attachments/assets/1d5b9fdf-9800-44e4-bdd5-f0964f93625f"
/>

> caused by using haiku 4.5 from the anthropic provider and then
swapping to sonnet 3.7 through zed, doing this does mess with prompt
caching but a model swap already invalidates that so it shouldn't have
any cost impact on end users
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement community champion Issues filed by our amazing community champions! 🫶

3 participants

@versecafe @JosephTLyons @rtfeldman