Language: Fix minor C++ completion label formatting issue #41544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
tomatitito
pushed a commit
to tomatitito/zed
that referenced
this pull request
Nov 7, 2025
…ries#41544) Closes zed-industries#39515 **Details:** - Improved logic for formatting completion labels, as some (such as `namespace`) were missing space characters. - Added extra logic as per stale PR zed-industries#39533 [comment](zed-industries#39533 (comment)) ensuring that cases where extra spaces are not necessary (such as functions) are not affected - I will note, I was not able to figure out how to fix the coloring of `namespace` within completion labels as mentioned in that comment, if someone would provide me with direction I would be happy to look into that too. Previous: <img width="812" height="530" alt="previous" src="https://github.com/user-attachments/assets/b38f1590-ca2d-489d-9dcb-2d478eb6ed03" /> Fixed: <img width="812" height="530" alt="fixed" src="https://github.com/user-attachments/assets/020b151d-e5d9-467e-99c1-5b0cab057169" /> Release Notes: - Fixed minor issue where some `clangd` labels would be missing a space in formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #39515
Details:
namespace) were missing space characters.namespacewithin completion labels as mentioned in that comment, if someone would provide me with direction I would be happy to look into that too.Previous:
Fixed:
Release Notes:
clangdlabels would be missing a space in formatting