Move @punctuation.delimiter before @operator capture #41663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
Collaborator
|
Nice catch. Thanks! |
P1n3appl3
pushed a commit
to bnjjj/zed
that referenced
this pull request
Nov 4, 2025
…41663) Closes zed-industries#41593 From what I understand the order of captures inside tree-sitter query files matters, and the last capture will win. `?` and `:` are captured by both `@operator` and `@punctuation.delimiter`.So in order for the ternary operator to win it should live after `@punctuation.delimiter`. Before: <img width="298" height="32" alt="Screenshot 2025-10-31 at 17 41 21" src="https://github.com/user-attachments/assets/af376e52-88be-4f62-9e2b-a106731f8145" /> After: <img width="303" height="39" alt="Screenshot 2025-10-31 at 17 41 33" src="https://github.com/user-attachments/assets/9a754ae9-0521-4c70-9adb-90a562404ce8" /> Release Notes: - Fixed an issue where the ternary operator symbols in TypeScript would not be highlighted as operators.
tomatitito
pushed a commit
to tomatitito/zed
that referenced
this pull request
Nov 7, 2025
…41663) Closes zed-industries#41593 From what I understand the order of captures inside tree-sitter query files matters, and the last capture will win. `?` and `:` are captured by both `@operator` and `@punctuation.delimiter`.So in order for the ternary operator to win it should live after `@punctuation.delimiter`. Before: <img width="298" height="32" alt="Screenshot 2025-10-31 at 17 41 21" src="https://github.com/user-attachments/assets/af376e52-88be-4f62-9e2b-a106731f8145" /> After: <img width="303" height="39" alt="Screenshot 2025-10-31 at 17 41 33" src="https://github.com/user-attachments/assets/9a754ae9-0521-4c70-9adb-90a562404ce8" /> Release Notes: - Fixed an issue where the ternary operator symbols in TypeScript would not be highlighted as operators.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41593
From what I understand the order of captures inside tree-sitter query files matters, and the last capture will win.
?and:are captured by both@operatorand@punctuation.delimiter.So in order for the ternary operator to win it should live after@punctuation.delimiter.Before:
After:
Release Notes: