Skip to content

Conversation

@Anthony-Eid
Copy link
Contributor

On Windows, clicking on a collab user icon in the title bar would minimize/expand Zed because the click would bleed through to the title bar. This PR fixes this by stopping propagation.

Before (On MacOS with double clicks to mimic the same behavior)

Screen.Recording.2025-11-01.at.5.20.50.PM.mov

After (On MacOS with double clicks to mimic the same behavior)

Screen.Recording.2025-11-01.at.5.20.25.PM.mov

Release Notes:

  • Windows: Fix clicking on user icon in title bar to follow minimizing/expanding Zed
Co-authored-by: Remco Smits <djsmits12@gmail.com>
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Nov 1, 2025
@Anthony-Eid Anthony-Eid enabled auto-merge (squash) November 1, 2025 21:27
@Anthony-Eid Anthony-Eid merged commit d5421ba into main Nov 2, 2025
64 of 70 checks passed
@Anthony-Eid Anthony-Eid deleted the dont-propagate-on-click-collab-follow branch November 2, 2025 07:35
tomatitito pushed a commit to tomatitito/zed that referenced this pull request Nov 7, 2025
On Windows, clicking on a collab user icon in the title bar would
minimize/expand Zed because the click would bleed through to the title
bar. This PR fixes this by stopping propagation.

#### Before (On MacOS with double clicks to mimic the same behavior)

https://github.com/user-attachments/assets/5a91f7ff-265a-4575-aa23-00b8d30daeed
#### After (On MacOS with double clicks to mimic the same behavior)

https://github.com/user-attachments/assets/e9fcb98f-4855-4f21-8926-2d306d256f1c

Release Notes:

- Windows: Fix clicking on user icon in title bar to follow
minimizing/expanding Zed

Co-authored-by: Remco Smits <djsmits12@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

2 participants