-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Refactor buffer headers to collapse on click #42021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
large click targets for mouse users. Before: Clicking a multi-buffer header opened the associated file, jumping the user out of context, sometime sunexpectedly. Users could collapse the header via the leftmost chevron and jump to the file via a keyboard shortcut. After: Clicking a multi-buffer header instead collapses the file. Clicking either the filename or the "Open file" button on the right of the header will open the file. The keyboard shortcut remains intact.
maxbrunsfeld
pushed a commit
that referenced
this pull request
Nov 6, 2025
Release Notes: Updated how clicking on multi-buffer headers works to provide better control and prevent unexpected navigation: Clicking the header now collapses/expands the file section instead of opening the file. Opening files can be done by clicking the filename or the "Open file" button on the right side of the header. Existing shortcuts continue to work: use the left chevron to collapse or your keyboard shortcut to jump to the file **Demo:** https://github.com/user-attachments/assets/dca9ccc5-bd98-416c-97af-43b4e4b2f903
maxbrunsfeld
pushed a commit
that referenced
this pull request
Nov 6, 2025
Release Notes: Updated how clicking on multi-buffer headers works to provide better control and prevent unexpected navigation: Clicking the header now collapses/expands the file section instead of opening the file. Opening files can be done by clicking the filename or the "Open file" button on the right side of the header. Existing shortcuts continue to work: use the left chevron to collapse or your keyboard shortcut to jump to the file **Demo:** https://github.com/user-attachments/assets/dca9ccc5-bd98-416c-97af-43b4e4b2f903
tomatitito
pushed a commit
to tomatitito/zed
that referenced
this pull request
Nov 7, 2025
Release Notes: Updated how clicking on multi-buffer headers works to provide better control and prevent unexpected navigation: Clicking the header now collapses/expands the file section instead of opening the file. Opening files can be done by clicking the filename or the "Open file" button on the right side of the header. Existing shortcuts continue to work: use the left chevron to collapse or your keyboard shortcut to jump to the file **Demo:** https://github.com/user-attachments/assets/dca9ccc5-bd98-416c-97af-43b4e4b2f903
tomatitito
pushed a commit
to tomatitito/zed
that referenced
this pull request
Nov 7, 2025
…d-industries#42235) zed-industries#42021 Made clicking on an excerpt title toggle it. This PR brings back the old behavior if a user is pressing the Alt key when clicking on an excerpt title. Release Notes: - N/A --------- Co-authored-by: Remco Smits <djsmits12@gmail.com>
11happy
pushed a commit
to 11happy/zed
that referenced
this pull request
Dec 1, 2025
Release Notes: Updated how clicking on multi-buffer headers works to provide better control and prevent unexpected navigation: Clicking the header now collapses/expands the file section instead of opening the file. Opening files can be done by clicking the filename or the "Open file" button on the right side of the header. Existing shortcuts continue to work: use the left chevron to collapse or your keyboard shortcut to jump to the file **Demo:** https://github.com/user-attachments/assets/dca9ccc5-bd98-416c-97af-43b4e4b2f903
11happy
pushed a commit
to 11happy/zed
that referenced
this pull request
Dec 1, 2025
…d-industries#42235) zed-industries#42021 Made clicking on an excerpt title toggle it. This PR brings back the old behavior if a user is pressing the Alt key when clicking on an excerpt title. Release Notes: - N/A --------- Co-authored-by: Remco Smits <djsmits12@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes:
Updated how clicking on multi-buffer headers works to provide better control and prevent unexpected navigation:
Clicking the header now collapses/expands the file section instead of opening the file.
Opening files can be done by clicking the filename or the "Open file" button on the right side of the header.
Existing shortcuts continue to work: use the left chevron to collapse or your keyboard shortcut to jump to the file
Demo:
https://github.com/user-attachments/assets/dca9ccc5-bd98-416c-97af-43b4e4b2f903