Skip to content

Fix panic when opening an invalid URL #42483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rtfeldman merged 8 commits into from
Nov 11, 2025
Merged

Fix panic when opening an invalid URL #42483

rtfeldman merged 8 commits into from
Nov 11, 2025

Conversation

@rtfeldman
Copy link
Contributor

@rtfeldman rtfeldman commented Nov 11, 2025

Now instead of a panic we see this:

Screenshot 2025-11-11 at 3 47 25 PM

Release Notes:

  • Trying to open invalid URLs in a browser now shows an error instead of panicking
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Nov 11, 2025
@rtfeldman rtfeldman changed the title Fix macos panic Nov 11, 2025
@rtfeldman rtfeldman enabled auto-merge (squash) November 11, 2025 20:55
@rtfeldman rtfeldman merged commit a56693d into main Nov 11, 2025
38 of 40 checks passed
@rtfeldman rtfeldman deleted the fix-macos-panic branch November 11, 2025 21:24
@ConradIrwin
Copy link
Member

ConradIrwin commented Nov 13, 2025

/cherry-pick stable
github-actions bot pushed a commit that referenced this pull request Nov 13, 2025
@rtfeldman
Fix panic when opening an invalid URL (#42483)
4bd12aa 
Now instead of a panic we see this:

<img width="511" height="132" alt="Screenshot 2025-11-11 at 3 47 25 PM"
src="https://github.com/user-attachments/assets/48ba2f41-c5c0-4030-9331-0d3acfbf9461"
/>


Release Notes:

- Trying to open invalid URLs in a browser now shows an error instead of
panicking
@zed-zippy zed-zippy bot mentioned this pull request Nov 13, 2025
Merged
zed-zippy bot added a commit that referenced this pull request Nov 13, 2025
@zed-zippy @rtfeldman
Fix panic when opening an invalid URL (#42483) (cherry-pick to stable) (
a6fc2a1 
#42637)

Cherry-pick of #42483 to stable

----
Now instead of a panic we see this:

<img width="511" height="132" alt="Screenshot 2025-11-11 at 3 47 25 PM"

src="https://github.com/user-attachments/assets/48ba2f41-c5c0-4030-9331-0d3acfbf9461"
/>


Release Notes:

- Trying to open invalid URLs in a browser now shows an error instead of
panicking

Co-authored-by: Richard Feldman <richard@zed.dev>
11happy pushed a commit to 11happy/zed that referenced this pull request Dec 1, 2025
@rtfeldman @11happy
Fix panic when opening an invalid URL (zed-industries#42483)
770cb10 
Now instead of a panic we see this:

<img width="511" height="132" alt="Screenshot 2025-11-11 at 3 47 25 PM"
src="https://github.com/user-attachments/assets/48ba2f41-c5c0-4030-9331-0d3acfbf9461"
/>


Release Notes:

- Trying to open invalid URLs in a browser now shows an error instead of
panicking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

3 participants

@rtfeldman @ConradIrwin