-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Add Restore File action in project_panel for git modified files #42490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Restore File action in project_panel for git modified files #42490
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @korbindeman on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
Hey @korbindeman just following up to let you know the team went pretty deep in more git feature work and we got behind on PR reviews. We're ramping back up and appreciate the patience! 👍 I know you've been waiting for a while now. |
|
No worries, thanks for the update! Appreciate you letting me know. I’m curious if you’re interested in merging this. I’ve found it useful and have added an “add to .gitignore” feature as well. Happy to update the PR with the addition if you’d like. |
|
@korbindeman can you remind me which GH issue this pertains to? |
|
Hey @katie-z-geer, as mentioned in the original PR comment, there is no existing issue related to this PR. It's a quality-of-life feature that I thought might be useful, especially considering the current focus on improving git UX. If you'd like me to open an issue for this, I'm happy to do that! |
|
Oh duh you're so right. I'll make sure this is on our PR boards this week (it's quality week) for review. Thank you! |
cameron1024
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR 🙏
I've tested it and it works, and the code looks good. A couple of small things but it's looking good :)
overoptimized code
|
@cameron1024 thanks for the review! I agree with your suggestions and have implemented them in the latest commit (2441287). |
cameron1024
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks 🙏
Co-authored-by: cameron <cameron.studdstreet@gmail.com>
…industries#42490) Co-authored-by: cameron <cameron.studdstreet@gmail.com>
…industries#42490) Co-authored-by: cameron <cameron.studdstreet@gmail.com>
This PR adds a "Git Restore" action to the project panel's right-click context menu for restoring files to their last committed state.
I frequently found myself wanting this feature and decided to implement it. I understand that there's no existing issue for this (that I know of). I'm happy to discuss whether this is a welcome addition and if the menu placement makes sense.
Release Notes: