Skip to content

gpui: Restore last window close behavior on macOS #43058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MrSubidubi merged 1 commit into from
Nov 19, 2025
Merged

gpui: Restore last window close behavior on macOS #43058

MrSubidubi merged 1 commit into from
Nov 19, 2025

Conversation

@MrSubidubi
Copy link
Member

@MrSubidubi MrSubidubi commented Nov 19, 2025

Follow-up to #42391

Release Notes:

  • Fixed an issue where Zed did not respect the on_last_window_closed setting on macOS
@MrSubidubi MrSubidubi enabled auto-merge (squash) November 19, 2025 12:56
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Nov 19, 2025
@MrSubidubi
Copy link
Member Author

MrSubidubi commented Nov 19, 2025

/cherry-pick preview
@MrSubidubi MrSubidubi merged commit 2c4fd24 into main Nov 19, 2025
37 of 39 checks passed
@MrSubidubi MrSubidubi deleted the on-last-window-close branch November 19, 2025 13:22
github-actions bot pushed a commit that referenced this pull request Nov 19, 2025
@MrSubidubi
gpui: Restore last window close behavior on macOS (#43058)
84268d9 
Follow-up to #42391

Release Notes:

- Fixed an issue where Zed did not respect the `on_last_window_closed`
setting on macOS
@zed-zippy zed-zippy bot mentioned this pull request Nov 19, 2025
Merged
zed-zippy bot added a commit that referenced this pull request Nov 19, 2025
@zed-zippy @MrSubidubi
gpui: Restore last window close behavior on macOS (#43058) (cherry-pi…
401637a 
…ck to preview) (#43062)

Cherry-pick of #43058 to preview

----
Follow-up to #42391

Release Notes:

- Fixed an issue where Zed did not respect the `on_last_window_closed`
setting on macOS

Co-authored-by: Finn Evers <finn@zed.dev>
mikayla-maki pushed a commit that referenced this pull request Nov 20, 2025
@MrSubidubi @mikayla-maki
gpui: Restore last window close behavior on macOS (#43058)
1f7d4f2 
Follow-up to #42391

Release Notes:

- Fixed an issue where Zed did not respect the `on_last_window_closed`
setting on macOS
11happy pushed a commit to 11happy/zed that referenced this pull request Dec 1, 2025
@MrSubidubi @11happy
gpui: Restore last window close behavior on macOS (zed-industries#43058)
2f7ea40 
Follow-up to zed-industries#42391

Release Notes:

- Fixed an issue where Zed did not respect the `on_last_window_closed`
setting on macOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

2 participants

@MrSubidubi