buffer_search: Fix replace buttons not working if search bar is not focused #43569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
dinocosta
force-pushed
the
42471-replace-button-focus
branch
from
39c6d47 to
f05bff5
Compare
Update the way that both `search::buffer_search::BufferSearchBar.replace_next` and `search::buffer_search::BufferSearchBar.replace_all` are registered as listeners, so that we don't require the replacement editor to be focused in order for these listeners to be active, only requiring the replacement mode to be active in the buffer search bar. This means that, even if the user is focused on the buffer editor, if the "Replace Next Match" or "Replace All Matches" buttons are clicked, the replacement will be performed.
dinocosta
force-pushed
the
42471-replace-button-focus
branch
from
f05bff5 to
5cbc77a
Compare
github-project-automation
bot
moved this to Community PRs
in Quality Week – December 2025
11happy
pushed a commit
to 11happy/zed
that referenced
this pull request
Dec 1, 2025
…ocused (zed-industries#43569) Update the way that both `search::buffer_search::BufferSearchBar.replace_next` and `search::buffer_search::BufferSearchBar.replace_all` are registered as listeners, so that we don't require the replacement editor to be focused in order for these listeners to be active, only requiring the replacement mode to be active in the buffer search bar. This means that, even if the user is focused on the buffer editor, if the "Replace Next Match" or "Replace All Matches" buttons are clicked, the replacement will be performed. Closes zed-industries#42471 Release Notes: - Fixed issue with buffer search bar where the replacement buttons ("Replace Next Match" & "Replace All Matches") wouldn't work if search bar was not focused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the way that both
search::buffer_search::BufferSearchBar.replace_nextandsearch::buffer_search::BufferSearchBar.replace_allare registered as listeners, so that we don't require the replacement editor to be focused in order for these listeners to be active, only requiring the replacement mode to be active in the buffer search bar.This means that, even if the user is focused on the buffer editor, if the "Replace Next Match" or "Replace All Matches" buttons are clicked, the replacement will be performed.
Closes #42471
Release Notes: