Skip to content

Conversation

@marcocondrache
Copy link
Contributor

@marcocondrache marcocondrache commented Nov 26, 2025

Closes #33650

Release Notes:

  • Added support for remote connections over IPv6
Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com>
Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com>
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Nov 26, 2025
@github-actions github-actions bot added the community champion Issues filed by our amazing community champions! 🫶 label Nov 26, 2025
@github-project-automation github-project-automation bot moved this to Community Champion PRs in Quality Week – December 2025 Nov 26, 2025
Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com>
Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com>
Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com>
@JosephTLyons
Copy link
Collaborator

Hey @marcocondrache - are you still working on anything here? I see a comment on you still needing to do some testing, is that current? Should we review or hold off a bit?

@marcocondrache
Copy link
Contributor Author

@JosephTLyons, the PR is ready. Sorry, I forgot to update the comment. Here are the tests I've conducted:

  • macOS to Linux using an IPv6 address: ssh root@address
  • macOS to Linux using an IPv4 address: ssh root@address
  • macOS to Linux using a hostname: ssh root@hostname

I haven't tested Windows to Linux since I don't have a machine for that.

A small note for @HactarCE: I had to change ssh_url to ssh_destination because OpenSSH doesn't support URLs with ssh:// and IPv6. According to the man documentation, "destination" and "URI" formats are equivalent.

@Veykril Veykril assigned Veykril and unassigned HactarCE Dec 16, 2025
@Veykril Veykril removed the request for review from HactarCE December 16, 2025 08:23
Copy link
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, if you rebase this I'll hit the merge button after our release today to let this cook over new years

Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com>
Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com>
Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com>
Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com>
@marcocondrache
Copy link
Contributor Author

@Veykril, I've rebased. Thanks for reviewing it

@Veykril Veykril merged commit 280864e into zed-industries:main Dec 17, 2025
23 checks passed
@github-project-automation github-project-automation bot moved this from Community Champion PRs to Done in Quality Week – December 2025 Dec 17, 2025
HactarCE pushed a commit that referenced this pull request Dec 17, 2025
Closes #33650

Release Notes:

- Added support for remote connections over IPv6

---------

Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com>
LivioGama pushed a commit to LivioGama/zed that referenced this pull request Jan 20, 2026
Closes zed-industries#33650

Release Notes:

- Added support for remote connections over IPv6

---------

Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com>
LivioGama pushed a commit to LivioGama/zed that referenced this pull request Jan 20, 2026
Closes zed-industries#33650

Release Notes:

- Added support for remote connections over IPv6

---------

Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement community champion Issues filed by our amazing community champions! 🫶

5 participants