Restrict icon paths to subdirectories of agent extensions #44183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
rtfeldman
added
the
area:ai
dui
pushed a commit
to dui/zed
that referenced
this pull request
Jan 16, 2026
This is a security fix to prevent path traversal attacks where a malicious extension could specify an icon path like "../../../etc/passwd" to access files outside its own directory. The fix adds a `resolve_extension_icon_path` function that: - Canonicalizes both the extension directory and the icon path - Verifies the resolved icon path stays within the extension directory - Returns None for invalid paths, preventing the icon from being loaded Fixes zed-industries#44183 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now agent extensions can specify icon paths that point anywhere. This changes it so that they can only specify icon paths that are subdirectories of the extension's root dir.
Release Notes: