vim: Fix global mark overwriting inconsistency #44765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
github-actions
bot
added
the
community champion
github-project-automation
bot
moved this to Community Champion PRs
in Quality Week – December 2025
Member
|
Thanks for the fix @AidanV! |
github-project-automation
bot
moved this from Community Champion PRs
to Done
in Quality Week – December 2025
CherryWorm
pushed a commit
to CherryWorm/zed
that referenced
this pull request
Dec 16, 2025
Closes zed-industries#43963 This issue was caused by the global marks not being deleted. Previously marking the first file `m A` <img width="1736" height="888" alt="Screenshot From 2025-12-13 01-37-55" src="https://github.com/user-attachments/assets/9e46747f-7bb3-4297-82d4-44a20ef9e91a" /> followed by marking the second file `m A` <img width="1736" height="888" alt="Screenshot From 2025-12-13 01-37-42" src="https://github.com/user-attachments/assets/0d126b47-2c42-475f-826a-173c0d5a1156" /> and navigating back to the first file <img width="1736" height="888" alt="Screenshot From 2025-12-13 01-37-30" src="https://github.com/user-attachments/assets/032fd0bd-ff71-4a12-987a-7f1743016f6d" /> shows that the mark still exists and was not properly deleted. After these changes the global mark in the original file is correctly overwritten. Added regression test for this. Release Notes: - Fixed bug where overwriting global Vim marks was inconsistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43963
This issue was caused by the global marks not being deleted. Previously marking the first file
m Afollowed by marking the second file
m Aand navigating back to the first file
shows that the mark still exists and was not properly deleted. After these changes the global mark in the original file is correctly overwritten.
Added regression test for this.
Release Notes: