diagnostics: Respect toolbar breadcrumbs setting in diagnostics panel #44974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The diagnostics panel was ignoring the user's toolbar.breadcrumbs setting and always showing breadcrumbs. This makes both BufferDiagnosticsEditor and ProjectDiagnosticsEditor check the EditorSettings to determine whether to display breadcrumbs. Fixes zed-industries#43020
|
We require contributors to sign our Contributor License Agreement, and we don't have @majiayu000 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
MrSubidubi
changed the title
Member
|
needs the CLA |
Contributor
Author
|
Hi! I have completed the cla ！ |
Contributor
Author
|
@cla-bot check |
|
We require contributors to sign our Contributor License Agreement, and we don't have @majiayu000 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
The cla-bot has been summoned, and re-checked this pull request! |
Contributor
Author
|
@cla-bot check |
cla-bot
bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
Member
|
Thanks! |
2 similar comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The diagnostics panel was ignoring the user's
toolbar.breadcrumbssetting and always showing breadcrumbs. This makes bothBufferDiagnosticsEditorandProjectDiagnosticsEditorcheck theEditorSettingsto determine whether to display breadcrumbs.Changes
buffer_diagnostics.rs: Updatedbreadcrumb_locationto checkEditorSettings::get_global(cx).toolbar.breadcrumbsdiagnostics.rs: Updatedbreadcrumb_locationto checkEditorSettings::get_global(cx).toolbar.breadcrumbsThis follows the same pattern used by the regular
Editorinitems.rs.Test plan
toolbar.breadcrumbstofalsein settings.jsondiagnostics: deploy current fileFixes #43020