Skip to content

editor: Strip trailing newlines from completion documentation #45342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Veykril merged 1 commit into from
Dec 19, 2025
Merged

editor: Strip trailing newlines from completion documentation #45342

Veykril merged 1 commit into from
Dec 19, 2025

Conversation

@errmayank
Copy link
Contributor

@errmayank errmayank commented Dec 19, 2025 •
edited
Loading

Closes #45337

Release Notes:

  • Fixed broken completion menu layout caused by trailing newlines in ty documentation
Before After
before after
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 19, 2025
@github-actions github-actions bot added the community champion Issues filed by our amazing community champions! 🫶 label Dec 19, 2025
@Veykril Veykril self-assigned this Dec 19, 2025
Veykril
Veykril approved these changes Dec 19, 2025
View reviewed changes
Copy link
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@Veykril Veykril enabled auto-merge (squash) December 19, 2025 08:34
@Veykril Veykril merged commit 596826f into zed-industries:main Dec 19, 2025
25 checks passed
@github-project-automation github-project-automation bot moved this from Community PRs to Done in Quality Week – December 2025 Dec 19, 2025
rtfeldman pushed a commit that referenced this pull request Jan 5, 2026
@errmayank
editor: Strip trailing newlines from completion documentation (#45342)
bc583ab 
Closes #45337

Release Notes:

- Fixed broken completion menu layout caused by trailing newlines in ty
documentation

<table>
  <tr>
    <td>Before</td>
    <td>After</td>
  </tr>
  <tr>
    <td>
<img width="756" height="875" alt="before"
src="https://github.com/user-attachments/assets/1d9da7d8-437a-4f03-8158-32ff1af9a428"
/>
    </td>
    <td>  
<img width="755" height="875" alt="after"
src="https://github.com/user-attachments/assets/dca31af3-e571-445a-b4a9-c300bb4c63fa"
/>
    </td>
  </tr>
</table>
LivioGama pushed a commit to LivioGama/zed that referenced this pull request Jan 20, 2026
@errmayank
editor: Strip trailing newlines from completion documentation (zed-in…
feaba21 
…dustries#45342)

Closes zed-industries#45337

Release Notes:

- Fixed broken completion menu layout caused by trailing newlines in ty
documentation

<table>
  <tr>
    <td>Before</td>
    <td>After</td>
  </tr>
  <tr>
    <td>
<img width="756" height="875" alt="before"
src="https://github.com/user-attachments/assets/1d9da7d8-437a-4f03-8158-32ff1af9a428"
/>
    </td>
    <td>  
<img width="755" height="875" alt="after"
src="https://github.com/user-attachments/assets/dca31af3-e571-445a-b4a9-c300bb4c63fa"
/>
    </td>
  </tr>
</table>
LivioGama pushed a commit to LivioGama/zed that referenced this pull request Jan 20, 2026
@errmayank
editor: Strip trailing newlines from completion documentation (zed-in…
42ee8f3 
…dustries#45342)

Closes zed-industries#45337

Release Notes:

- Fixed broken completion menu layout caused by trailing newlines in ty
documentation

<table>
  <tr>
    <td>Before</td>
    <td>After</td>
  </tr>
  <tr>
    <td>
<img width="756" height="875" alt="before"
src="https://github.com/user-attachments/assets/1d9da7d8-437a-4f03-8158-32ff1af9a428"
/>
    </td>
    <td>  
<img width="755" height="875" alt="after"
src="https://github.com/user-attachments/assets/dca31af3-e571-445a-b4a9-c300bb4c63fa"
/>
    </td>
  </tr>
</table>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement community champion Issues filed by our amazing community champions! 🫶

2 participants

@errmayank @Veykril